Page MenuHomeFreeBSD
Differential D36636

if_clone: migrate some consumers to the new KPI
ClosedPublic
Actions

Authored by melifaro on Sep 20 2022, 2:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 28, 4:28 PM
Unknown Object (File)
Feb 10 2024, 6:37 PM
Unknown Object (File)
Dec 20 2023, 7:28 AM
Unknown Object (File)
Sep 5 2023, 12:31 PM
Unknown Object (File)
Aug 31 2023, 11:37 AM
Unknown Object (File)
Aug 31 2023, 11:33 AM
Unknown Object (File)
Aug 31 2023, 11:23 AM
Unknown Object (File)
Jun 24 2023, 8:15 AM
View All 19 Files
Subscribers
ae
farrokhi
glebius
imp

Details

Reviewers
glebius
kp
Group Reviewers
network
Commits
rG91ebcbe02a48: if_clone: migrate some consumers to the new KPI.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

melifaro created this revision.Sep 20 2022, 2:52 PM
Herald added subscribers: glebius, farrokhi, ae, imp. · View Herald TranscriptSep 20 2022, 2:52 PM
melifaro requested review of this revision.Sep 20 2022, 2:52 PM
Harbormaster completed remote builds in B47459: Diff 110740.Sep 20 2022, 2:52 PM
melifaro added a parent revision: D36632: if_clone: rework cloning KPI.Sep 20 2022, 2:52 PM
melifaro added reviewers: network, glebius, kp.
kp added a comment.Sep 21 2022, 12:27 PM

LGTM, at least for bridge, epair, ovpn, vlan and pflog.

stf panics during its test.

sys/net/if_stf.c
312

I think we're forgetting *ifpp = ifp; here.

I see this panic:

login: panic: Assertion *ifpp != NULL failed at /usr/src/sys/net/if_clone.c:263
cpuid = 10
time = 1663762123
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe015f2eea20
vpanic() at vpanic+0x151/frame 0xfffffe015f2eea70
panic() at panic+0x43/frame 0xfffffe015f2eead0
if_clone_createif() at if_clone_createif+0x24e/frame 0xfffffe015f2eeb20
ifc_create_ifp() at ifc_create_ifp+0xe2/frame 0xfffffe015f2eeb80
if_clone_create() at if_clone_create+0x34/frame 0xfffffe015f2eebd0
ifioctl() at ifioctl+0x92b/frame 0xfffffe015f2eecc0
kern_ioctl() at kern_ioctl+0x202/frame 0xfffffe015f2eed30
sys_ioctl() at sys_ioctl+0x12a/frame 0xfffffe015f2eee00
amd64_syscall() at amd64_syscall+0x12e/frame 0xfffffe015f2eef30
fast_syscall_common() at fast_syscall_common+0xf8/frame 0xfffffe015f2eef30
--- syscall (54, FreeBSD ELF64, sys_ioctl), rip = 0x3336352ab7aa, rsp = 0x33362fd09528, rbp = 0x33362fd09540 ---
KDB: enter: panic
This revision was not accepted when it landed; it landed in state Needs Review.Sep 22 2022, 12:32 PM
Closed by commit rG91ebcbe02a48: if_clone: migrate some consumers to the new KPI. (authored by melifaro). · Explain Why
This revision was automatically updated to reflect the committed changes.
melifaro added a commit: rG91ebcbe02a48: if_clone: migrate some consumers to the new KPI..
melifaro marked an inline comment as done.Sep 22 2022, 12:33 PM
melifaro added inline comments.
sys/net/if_stf.c
312

Indeed, thank you!

zlei mentioned this in D37740: wg(4): switch to the new if_clone interface.Dec 20 2022, 7:55 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
usb/
23 lines
net/
28 lines
22 lines
33 lines
32 lines
14 lines
18 lines
30 lines
32 lines
34 lines
net80211/
25 lines
netpfil/
pf/
37 lines

Diff 110849

View Options

sys/dev/usb/usb_pf.c

Loading...
View Options

sys/net/if_bridge.c

Loading...
View Options

sys/net/if_epair.c

Loading...
View Options

sys/net/if_lagg.c

Loading...
View Options

sys/net/if_loop.c

Loading...
View Options

sys/net/if_ovpn.c

Loading...
View Options

sys/net/if_stf.c

Loading...
View Options

sys/net/if_tuntap.c

Loading...
View Options

sys/net/if_vlan.c

Loading...
View Options

sys/net/if_vxlan.c

Loading...
View Options

sys/net80211/ieee80211_freebsd.c

Loading...
View Options

sys/netpfil/pf/if_pflog.c

Loading...