ip_output: always increase "cantfrag" stat if ip_fragment() fails
ClosedPublic
Actions

Authored by glebius on Sep 14 2022, 9:21 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Feb 8, 11:17 AM

	Unknown Object (File)
	Sun, Feb 8, 2:30 AM

	Unknown Object (File)
	Sat, Jan 31, 7:41 AM

	Unknown Object (File)
	Dec 14 2025, 4:29 AM

	Unknown Object (File)
	Nov 23 2025, 5:06 AM

	Unknown Object (File)
	Nov 13 2025, 10:44 PM

	Unknown Object (File)
	Nov 5 2025, 8:21 PM

	Unknown Object (File)
	Oct 13 2025, 8:24 PM

View All 99 Files

Subscribers

imp

melifaro

Details

Reviewers

mjg
melifaro

Group Reviewers

network

Commits

rGda6715bbb125: ip_output: always increase "cantfrag" stat if ip_fragment() fails

Summary

While here, join two unlikely cases into one if clause.

Submitted by: Ivan Rozhuk <rozhuk.im gmail.com>
PR: 265718

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Sep 14 2022, 9:21 PM

Herald added subscribers: melifaro, imp. · View Herald TranscriptSep 14 2022, 9:21 PM

glebius requested review of this revision.Sep 14 2022, 9:21 PM

Harbormaster completed remote builds in B47400: Diff 110578.Sep 14 2022, 9:22 PM

mjg accepted this revision as: mjg.Sep 14 2022, 10:51 PM

This revision is now accepted and ready to land.Sep 14 2022, 10:51 PM

melifaro accepted this revision.Sep 14 2022, 11:16 PM

Closed by commit rGda6715bbb125: ip_output: always increase "cantfrag" stat if ip_fragment() fails (authored by glebius). · Explain WhySep 15 2022, 2:23 AM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGda6715bbb125: ip_output: always increase "cantfrag" stat if ip_fragment() fails.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

ip_output.c

14 lines

Diff 110586

View Options

ip_output: always increase "cantfrag" stat if ip_fragment() failsClosedPublicActions