- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Dec 15 2020
Dec 13 2020
Dec 10 2020
Dec 5 2020
Nov 25 2020
Nov 24 2020
In D27310#610450, @kib wrote:I do not see this EINTR and EINPROGRESS change in the most recent version of POSIX I have, IEEE Std 1003.1™-2017.
The referenced austin group ticket even went as far as propose posix_close() with some retry flag, which again was not added. More, there were strong objections from Linux side arguing that EINTR behavior should be as it is de-facto implemented by Linux and FreeBSD: file is always closed.
Nov 22 2020
Restarting a close() would indeed be very bad, but returning [EINTR] might cause userland to do the same.
Nov 19 2020
Having this kind of possibly mysterious errors documented is very useful.
My suggestion is to change all the exit statuses that were changed to sysexits codes here to 2 instead.
Nov 16 2020
In D27216#607710, @gbe wrote:In D27216#607705, @jilles wrote:A pthread implementation "libc_r" was already added in 2.2-release, which contained most of these functions.
Nov 14 2020
A pthread implementation "libc_r" was already added in 2.2-release, which contained most of these functions.
Nov 11 2020
Exit statuses should implement a protocol between the calling and called process. Since only 8 bits (or 32 if the calling process uses waitid()) are available, there is not much flexibility. I think distinctions between different exit statuses should have a purpose, while most of the sysexits codes categorize errors without a clear purpose. If more flexibility is needed, a channel with more capacity should be used.
Oct 19 2020
Oct 18 2020
Oct 4 2020
This complies to https://www.austingroupbugs.net/bug_view_page.php?bug_id=508 which is planned for POSIX issue8 (in a few years).
Sep 12 2020
Perhaps it is better to match sockstat (D26413) and make the option -C instead of -c.
Sep 1 2020
Aug 28 2020
Aug 22 2020
Aug 3 2020
I found a reason to touch this code, but otherwise I'm a bit surprised about a change here.
Aug 1 2020
Jul 30 2020
Jul 26 2020
Jul 16 2020
This change may cause breakage in setups where the chroot does not have /etc/pwd.db and related files. Given that chroot(8) has worked like this since 2003, why change it now?
Jul 14 2020
Jul 12 2020
Jul 10 2020
I think the best way forward is to start with -@ first and leave -l output as it is, at first.
Jul 9 2020
Jul 1 2020
Since struct timeval is mostly obsoleted by struct timespec, I suggest adding this only when there is existing code using it.
Jun 28 2020
Jun 23 2020
Jun 21 2020
Jun 18 2020
Jun 14 2020
Jun 9 2020
May 30 2020
May 29 2020
In D25033#551601, @kevans wrote:In D25033#551509, @jilles wrote:The dup2 part looks good.
May 28 2020
The dup2 part looks good.
May 24 2020
May 23 2020
May 22 2020
May 19 2020
Although there is nothing wrong with this per se, applications can deal with this problem more easily using getline(3) (which is also standard).
May 16 2020
May 15 2020
May 13 2020
May 12 2020
read(2) on a directory seems only useful for educational or debugging purposes. These purposes are better served by a different API.
Apr 28 2020
Apr 27 2020
Apr 25 2020
Apr 22 2020
Apr 20 2020
Feel free to commit this revision as is. I will handle -h in mkbuiltins.
Apr 18 2020
A follow-up is to delete -h from mkbuiltins and builtins.def.
Apr 17 2020
This solution looks inconsistent. Either fc and bind are always available (writing an error message if history is not compiled in), in which case mkbuiltins should not be omitting them, or they are not available if history is not compiled in, in which case the functions should not be defined at all if history is not compiled in.
Apr 14 2020
Disabling utx boot and utx shutdown does not prevent other parts of the system writing to the utx files. So by itself this disable creates utx files that are less useful. Disabling utx completely needs patching, at least the way things are now.
Apr 4 2020
Some people wrongly add whitespace via copy and paste, but let's be consistent with login, passwd, etc.
Mar 25 2020
Fine with me, assuming it still builds with recent GCC as well.
Mar 4 2020
Mar 2 2020
MAINTAINERS says openssh is maintained by des, who accepts reviews via email only (no phabricator).
Feb 24 2020
In D23802#523379, @kib wrote:The buffer was written by the function, this is my point of the aliasing breakage.
Feb 19 2020
Feb 18 2020
Feb 16 2020
The bin/sh part looks OK.
Feb 12 2020
Feb 9 2020
Feb 4 2020
Jan 24 2020
What is the point of fputc_unlocked() given that putc_unlocked() already exists?
Jan 17 2020
Hmm, https://reviews.freebsd.org/D17083 proposes to change qsort_r() argument order to glibc's since that is likely to become POSIX standard and is slightly better than our order.
Jan 15 2020
In D12773#508215, @cem wrote:In fact, a very similar scenario is possible _today_ with sigprocmask:
Jan 14 2020
Jan 7 2020
The mq_notify() mechanism indeed needs to be considered here, but I think it already handles that:
Jan 1 2020
Dec 30 2019
Dec 16 2019
Dec 11 2019
Adding INTOFF/INTON around malloc/free prevents unsafety due to interrupting the allocator, but does not prevent memory leaks or double frees due to the administration getting out of sync with the allocator (for example, if the INTON in ckmalloc() notices an interrupt, the allocated memory will leak). It would make more sense if ckmalloc/ckrealloc/ckfree merely asserted that INTON is in effect. I experimented with that earlier but did not follow through.
Dec 7 2019
Dec 6 2019
Dec 4 2019
I think the part "to all processes with the same uid as the user" is rather vague now, and would probably be better written as "to all processes which the caller has permission to", given that permission checks are quite complicated nowadays.
Oct 18 2019
Historically, another reason was performance. For example, https://svnweb.freebsd.org/base?view=revision&revision=76801 which changed make(1) to be statically linked states performance as the reason.
Oct 9 2019
Looks good with one grammar issue. Don't forget to bump .Dd.