Page MenuHomeFreeBSD

Extend sockstat to display the TCP congestion control
ClosedPublic

Authored by tuexen on Sep 12 2020, 2:06 PM.

Details

Summary

This patch adds the -C option to sockstat, which enables the displaying of the name of the congestion control module used by a TCP connection.

This depends on D26412.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

usr.bin/sockstat/sockstat.c
1150 ↗(On Diff #76946)

Why not structure this right away similar to the above, to allow easy extention if additional columns get added later?

Also, if TCP specific columns are kept at the tail, you could check for IPPROTO_TCP first - or do we have STCP specific columns already? Also, wouldn't SCTP also be able to use different CC's, thinking about it?

Address Richard's comment.

usr.bin/sockstat/sockstat.c
1150 ↗(On Diff #76946)

Code updated to use the same patter as above.

Yes, SCTP has CC modules and I plan to make them supported here in the future, too.

This revision is now accepted and ready to land.Sep 12 2020, 10:06 PM