Page MenuHomeFreeBSD

Extend sockstat to display the TCP congestion control
ClosedPublic

Authored by tuexen on Sep 12 2020, 2:06 PM.
Tags
None
Referenced Files
F107193641: D26413.diff
Sat, Jan 11, 11:29 AM
Unknown Object (File)
Wed, Dec 25, 12:16 PM
Unknown Object (File)
Nov 21 2024, 9:12 AM
Unknown Object (File)
Oct 9 2024, 1:39 PM
Unknown Object (File)
Oct 3 2024, 9:49 AM
Unknown Object (File)
Sep 18 2024, 8:27 AM
Unknown Object (File)
Sep 14 2024, 1:32 AM
Unknown Object (File)
Sep 5 2024, 10:16 AM
Subscribers

Details

Summary

This patch adds the -C option to sockstat, which enables the displaying of the name of the congestion control module used by a TCP connection.

This depends on D26412.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 33522

Event Timeline

usr.bin/sockstat/sockstat.c
1150

Why not structure this right away similar to the above, to allow easy extention if additional columns get added later?

Also, if TCP specific columns are kept at the tail, you could check for IPPROTO_TCP first - or do we have STCP specific columns already? Also, wouldn't SCTP also be able to use different CC's, thinking about it?

Address Richard's comment.

usr.bin/sockstat/sockstat.c
1150

Code updated to use the same patter as above.

Yes, SCTP has CC modules and I plan to make them supported here in the future, too.

This revision is now accepted and ready to land.Sep 12 2020, 10:06 PM