Further refinements of ptsname_r(3) interface:

[delphij]

Summary

• Hide ptsname_r under __BSD_VISIBLE for now as the specification is not finalized at this time.
• Keep Symbol.map sorted.
• Avoid the interposing of ptsname_r(3) from an user application from breaking ptsname(3) by making the implementation a static method and call the static function from ptsname(3) instead.

Reported by: kib

[jilles]

include/stdlib.h

239 ↗

(On Diff #78393)

This should probably go with the other function prototypes in a logical order (it seems mostly alphabetical now).

[kib]

lib/libc/stdlib/ptsname.c

104 ↗

(On Diff #78393)

Why do you want to make the function weak ?

106 ↗

(On Diff #78393)

It is better to

1. Make __ptsname_r non-static (but do not add it to Symbol.map)
2. Define ptsname_r as an alias for __ptsname_r. Look above how e.g. grantpt is defined.

Then you do not need this trivial wrapper.

[delphij]

Address reviewer comments.

[delphij]

Please take another look, thanks!