Differential D26845

Further refinements of ptsname_r(3) interface:
ClosedPublic
Actions

Authored by delphij on Oct 18 2020, 7:47 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Sep 27, 5:35 AM

	Unknown Object (File)
	Sat, Sep 27, 12:24 AM

	Unknown Object (File)
	Fri, Sep 26, 8:32 AM

	Unknown Object (File)
	Thu, Sep 25, 5:58 AM

	Unknown Object (File)
	Thu, Sep 25, 4:00 AM

	Unknown Object (File)
	Tue, Sep 23, 8:30 PM

	Unknown Object (File)
	Thu, Sep 18, 12:29 AM

	Unknown Object (File)
	Wed, Sep 17, 4:02 PM

Subscribers

Details

Reviewers

kib
jilles
emaste

Commits

rS366866: Further refinements of ptsname_r(3) interface:

Summary

Hide ptsname_r under __BSD_VISIBLE for now as the specification is not finalized at this time.
Keep Symbol.map sorted.
Avoid the interposing of ptsname_r(3) from an user application from breaking ptsname(3) by making the implementation a static method and call the static function from ptsname(3) instead.

Reported by: kib

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

delphij requested review of this revision.Oct 18 2020, 7:47 PM

delphij created this revision.

Harbormaster completed remote builds in B34246: Diff 78393.Oct 18 2020, 7:47 PM

jilles added inline comments.Oct 18 2020, 9:05 PM

include/stdlib.h
239 ↗	(On Diff #78393)	This should probably go with the other function prototypes in a logical order (it seems mostly alphabetical now).

kib added inline comments.Oct 18 2020, 9:08 PM

lib/libc/stdlib/ptsname.c
104 ↗	(On Diff #78393)	Why do you want to make the function weak ?
106 ↗	(On Diff #78393)	It is better to Make __ptsname_r non-static (but do not add it to Symbol.map) Define ptsname_r as an alias for __ptsname_r. Look above how e.g. grantpt is defined. Then you do not need this trivial wrapper.

Address reviewer comments.

Harbormaster completed remote builds in B34254: Diff 78410.Oct 19 2020, 4:30 AM

Please take another look, thanks!

kib accepted this revision.Oct 19 2020, 7:09 AM

This revision is now accepted and ready to land.Oct 19 2020, 7:09 AM

jilles accepted this revision.Oct 19 2020, 7:53 PM

Closed by commit rS366866: Further refinements of ptsname_r(3) interface: (authored by delphij). · Explain WhyOct 20 2020, 1:30 AM

This revision was automatically updated to reflect the committed changes.

delphij added a commit: rS366866: Further refinements of ptsname_r(3) interface:.

Herald added a subscriber: imp. · View Herald TranscriptOct 20 2020, 1:30 AM

Revision Contents
Changeset List

Path

Size

head/

include/

14 lines

lib/

libc/

stdlib/

2 lines

12 lines

Diff 78483

head/include/stdlib.h

Loading...

head/lib/libc/stdlib/Symbol.map

Loading...

head/lib/libc/stdlib/ptsname.c

Loading...