Page MenuHomeFreeBSD
Feed Advanced Search

Jul 2 2016

truckman committed rP417911: Upgrade axa to version 1.3.0..
Upgrade axa to version 1.3.0.
Jul 2 2016, 7:13 AM

Jul 1 2016

truckman added inline comments to D6928: Dummynet PIE AQM: Fix kernel panic due to a race condition in callout.
Jul 1 2016, 4:16 PM

Jun 30 2016

truckman added inline comments to D6928: Dummynet PIE AQM: Fix kernel panic due to a race condition in callout.
Jun 30 2016, 7:50 AM
truckman added inline comments to D6928: Dummynet PIE AQM: Fix kernel panic due to a race condition in callout.
Jun 30 2016, 6:11 AM

Jun 29 2016

truckman added a comment to D6928: Dummynet PIE AQM: Fix kernel panic due to a race condition in callout.

Are similar fixes needed elsewhere in the AQM code?

Jun 29 2016, 5:04 PM
truckman added inline comments to D6928: Dummynet PIE AQM: Fix kernel panic due to a race condition in callout.
Jun 29 2016, 7:28 AM
truckman added inline comments to D6928: Dummynet PIE AQM: Fix kernel panic due to a race condition in callout.
Jun 29 2016, 2:22 AM

Jun 28 2016

truckman added inline comments to D6928: Dummynet PIE AQM: Fix kernel panic due to a race condition in callout.
Jun 28 2016, 6:02 PM

Jun 23 2016

truckman added a comment to D6928: Dummynet PIE AQM: Fix kernel panic due to a race condition in callout.

By switching to callout_drain() and removing the cleanup code from the callout, it should be possible to further simplify the code by getting rid of CALLOUT_RETURNUNLOCKED and removing the mtx_unlock() calls from the callout.

Jun 23 2016, 5:56 PM
truckman committed rP417378: Upgrade to upstream svn revision 1749607..
Upgrade to upstream svn revision 1749607.
Jun 23 2016, 3:30 PM
truckman added a comment to D6928: Dummynet PIE AQM: Fix kernel panic due to a race condition in callout.

It would be better to associate the callout with a mutex and use callout_async_drain() to catch the final teardown.

Jun 23 2016, 8:32 AM
truckman added inline comments to D6928: Dummynet PIE AQM: Fix kernel panic due to a race condition in callout.
Jun 23 2016, 5:59 AM
truckman added inline comments to D6928: Dummynet PIE AQM: Fix kernel panic due to a race condition in callout.
Jun 23 2016, 4:00 AM

Jun 20 2016

truckman closed D6386: Allow ECN to be accepted for incoming TCP connections without requesting it for outgoing connections and make this the default by committing rS302032: MFC r300240.
Jun 20 2016, 7:01 PM
truckman committed rS302032: MFC r300240.
MFC r300240
Jun 20 2016, 7:01 PM

Jun 15 2016

truckman committed rS301921: MFC r301596.
MFC r301596
Jun 15 2016, 6:42 AM
truckman committed rS301920: MFC r301592.
MFC r301592
Jun 15 2016, 6:40 AM
truckman committed rS301919: MFC r301582.
MFC r301582
Jun 15 2016, 6:33 AM
truckman committed rS301917: MFC r299484, r301574.
MFC r299484, r301574
Jun 15 2016, 6:27 AM

Jun 10 2016

truckman committed rS301772: MFC r300779, r300781, r300783, r300784, r300949, r301162, r301180.
MFC r300779, r300781, r300783, r300784, r300949, r301162, r301180
Jun 10 2016, 12:00 AM

Jun 8 2016

truckman closed D6755: Don't leak olinep if malloc() fails by committing rS301596: Don't leak olinep if malloc() fails..
Jun 8 2016, 10:25 AM
truckman committed rS301596: Don't leak olinep if malloc() fails..
Don't leak olinep if malloc() fails.
Jun 8 2016, 10:25 AM
truckman retitled D6757: Fix file descriptor and memory leaks in libdpv from to Fix file descriptor and memory leaks in libdpv.
Jun 8 2016, 10:00 AM
truckman closed D6756: Don't leak addrinfo if ai->ai_addrlen <= minsiz test fails by committing rS301592: Don't leak addrinfo if ai->ai_addrlen <= minsiz test fails..
Jun 8 2016, 9:40 AM
truckman committed rS301592: Don't leak addrinfo if ai->ai_addrlen <= minsiz test fails..
Don't leak addrinfo if ai->ai_addrlen <= minsiz test fails.
Jun 8 2016, 9:40 AM
truckman retitled D6756: Don't leak addrinfo if ai->ai_addrlen <= minsiz test fails from to Don't leak addrinfo if ai->ai_addrlen <= minsiz test fails.
Jun 8 2016, 8:48 AM
truckman retitled D6755: Don't leak olinep if malloc() fails from to Don't leak olinep if malloc() fails.
Jun 8 2016, 8:25 AM
truckman committed rS301582: Explicitly NUL terminate the buffer filled by fread()..
Explicitly NUL terminate the buffer filled by fread().
Jun 8 2016, 5:32 AM
truckman retitled D6752: Eliminate some if (!eof) tests that should always be true. from to Eliminate some if (!eof) tests that should always be true..
Jun 8 2016, 2:39 AM
truckman committed rS301574: Fix a (false positive?) Argument cannot be negative coverity defect..
Fix a (false positive?) Argument cannot be negative coverity defect.
Jun 8 2016, 2:14 AM
truckman closed D6552: Another try at fixing Coverity 1008328 in /bin/sh by committing rS301571: MFC r301139.
Jun 8 2016, 1:17 AM
truckman committed rS301571: MFC r301139.
MFC r301139
Jun 8 2016, 1:17 AM

Jun 7 2016

truckman retitled D6751: Fix use-after-free error in nscd (CID 1006083) from to Fix use-after-free error in nscd (CID 1006083).
Jun 7 2016, 11:29 PM
truckman committed rS301557: MFC r300564.
MFC r300564
Jun 7 2016, 4:56 PM
truckman committed rS301556: MFC r299921.
MFC r299921
Jun 7 2016, 4:53 PM
truckman committed rP416493: Fix type for abs() calls in graphics/inkscape.
Fix type for abs() calls in graphics/inkscape
Jun 7 2016, 4:14 AM

Jun 6 2016

truckman committed rP416491: Fix type for abs() calls in net/opal.
Fix type for abs() calls in net/opal
Jun 6 2016, 11:55 PM

Jun 3 2016

truckman committed rS301231: MFC r266941, r266955.
MFC r266941, r266955
Jun 3 2016, 12:49 AM

Jun 2 2016

truckman committed rS301180: Belatedly bump .Dd date for Dummynet AQM import in r300779..
Belatedly bump .Dd date for Dummynet AQM import in r300779.
Jun 2 2016, 12:42 AM

Jun 1 2016

truckman committed rS301178: MFC r300705 (compensating for fortune moving from games to usr.bin).
MFC r300705 (compensating for fortune moving from games to usr.bin)
Jun 1 2016, 10:39 PM
truckman committed rS301162: Replace constant expressions that contain multiplications by.
Replace constant expressions that contain multiplications by
Jun 1 2016, 8:04 PM
truckman accepted D6651: keyserv(1): Wrong comparison in load_des().
Jun 1 2016, 6:21 PM
truckman committed rS301156: MFC r300706.
MFC r300706
Jun 1 2016, 5:58 PM
truckman committed rS301155: MFC r300692.
MFC r300692
Jun 1 2016, 5:47 PM
truckman committed rS301154: MFC r300666.
MFC r300666
Jun 1 2016, 5:45 PM
truckman committed rS301153: MFC r300665.
MFC r300665
Jun 1 2016, 5:43 PM
truckman committed rS301152: MFC r300664.
MFC r300664
Jun 1 2016, 5:41 PM
truckman committed rS301151: MFC r300662.
MFC r300662
Jun 1 2016, 5:39 PM
truckman committed rS301150: MFC r300660.
MFC r300660
Jun 1 2016, 5:37 PM
truckman committed rS301149: MFC r300649.
MFC r300649
Jun 1 2016, 5:35 PM
truckman committed rS301148: MFC r300648.
MFC r300648
Jun 1 2016, 5:33 PM
truckman committed rS301147: MFC r300643.
MFC r300643
Jun 1 2016, 5:31 PM
truckman committed rS301146: MFC r300642.
MFC r300642
Jun 1 2016, 5:29 PM
truckman committed rS301144: MFC r300636.
MFC r300636
Jun 1 2016, 5:20 PM
truckman committed rS301143: MFC r300635.
MFC r300635
Jun 1 2016, 5:18 PM
truckman committed rS301142: MFC r300633.
MFC r300633
Jun 1 2016, 5:16 PM
truckman committed rS301141: MFC r300632.
MFC r300632
Jun 1 2016, 5:14 PM
truckman committed rS301140: MFC r300442.
MFC r300442
Jun 1 2016, 5:10 PM
truckman committed rS301139: The (i < PROMPTLEN - 1) test added by r300442 in the code for the default.
The (i < PROMPTLEN - 1) test added by r300442 in the code for the default
Jun 1 2016, 4:56 PM

May 30 2016

truckman accepted D6623: Bounds check rpcbs_rmtcall(..) to ensure rtype is less than RPCBVERS_STAT.
May 30 2016, 9:00 PM
truckman added a comment to D6623: Bounds check rpcbs_rmtcall(..) to ensure rtype is less than RPCBVERS_STAT.

That looks correct to me.

May 30 2016, 8:59 PM

May 29 2016

truckman committed rS300950: Now that PIE is free of runtime floating point, revert r300853 to.
Now that PIE is free of runtime floating point, revert r300853 to
May 29 2016, 7:29 AM
truckman committed rS300949: Cast some expressions that multiply a long long constant by a.
Cast some expressions that multiply a long long constant by a
May 29 2016, 7:24 AM

May 27 2016

truckman committed rS300853: Disconnect PIE from the build until it is free of floating point math..
Disconnect PIE from the build until it is free of floating point math.
May 27 2016, 5:07 PM

May 26 2016

truckman committed rS300784: Include the new AQM files when compiling a kernel with options DUMMYNET..
Include the new AQM files when compiling a kernel with options DUMMYNET.
May 26 2016, 10:07 PM
truckman committed rS300783: Correct a typo in a comment..
Correct a typo in a comment.
May 26 2016, 10:03 PM
truckman committed rS300781: Modify BOUND_VAR() macro to wrap all of its arguments in () and tweak.
Modify BOUND_VAR() macro to wrap all of its arguments in () and tweak
May 26 2016, 9:45 PM
truckman committed rS300779: Import Dummynet AQM version 0.2.1 (CoDel, FQ-CoDel, PIE and FQ-PIE)..
Import Dummynet AQM version 0.2.1 (CoDel, FQ-CoDel, PIE and FQ-PIE).
May 26 2016, 9:40 PM
truckman closed D6388: CoDel, FQ-CoDel, PIE and FQ-PIE for ipfw/dummynet by committing rS300779: Import Dummynet AQM version 0.2.1 (CoDel, FQ-CoDel, PIE and FQ-PIE)..
May 26 2016, 9:40 PM
truckman added a comment to D6572: Quell false positives in svc_vc_create and svc_vc_create_conn with cd and xprt.
In D6572#138990, @cem wrote:

I don't dislike the if() { } cleanup pattern on exit, even if it is impossible with today's code.

Does this code ever get compiled in userspace? Do the mem_alloc routines do the same thing there?

May 26 2016, 4:23 PM
truckman accepted D6572: Quell false positives in svc_vc_create and svc_vc_create_conn with cd and xprt.

Looks fine to me.

May 26 2016, 12:23 PM
truckman committed rP415875: Fix build of openoffice-4 and openoffice-devel with libc++ 3.8.0..
Fix build of openoffice-4 and openoffice-devel with libc++ 3.8.0.
May 26 2016, 6:02 AM
truckman committed rS300706: Avoid buffer overflow or truncation when constructing path_zoneinfo_file..
Avoid buffer overflow or truncation when constructing path_zoneinfo_file.
May 26 2016, 1:45 AM
truckman committed rS300705: Avoid buffer overflow when copying the input file name and appending .dat..
Avoid buffer overflow when copying the input file name and appending .dat.
May 26 2016, 1:33 AM
truckman removed reviewers for D6526: Fix Coverity CIDs 1018708 and 1018709 in libstand/nfs.c (and other fixes): rmacklem, mav.
May 26 2016, 12:09 AM
truckman abandoned D6526: Fix Coverity CIDs 1018708 and 1018709 in libstand/nfs.c (and other fixes).
May 26 2016, 12:07 AM
truckman reclaimed D6526: Fix Coverity CIDs 1018708 and 1018709 in libstand/nfs.c (and other fixes).
May 26 2016, 12:06 AM

May 25 2016

truckman committed rS300692: Close the input FILE * in read_file() and the output FILE * in write_file().
Close the input FILE * in read_file() and the output FILE * in write_file()
May 25 2016, 6:38 PM
truckman closed D6554: Fix CID 977702 (Resource leak) in ed io.c by committing rS300692: Close the input FILE * in read_file() and the output FILE * in write_file().
May 25 2016, 6:38 PM
truckman updated the diff for D6554: Fix CID 977702 (Resource leak) in ed io.c.

Match existing {} style

May 25 2016, 6:01 PM
truckman added inline comments to D6554: Fix CID 977702 (Resource leak) in ed io.c.
May 25 2016, 4:28 PM
truckman closed D6557: Fix Coverity CIDs 1356044 and 1356045 Unintended sign extension.

Closed by commit rS300686: Fix a couple of Coverity Unintended sign extension sign extension (authored by truckman).

May 25 2016, 4:13 PM
truckman closed D6558: Fix Coverity CIDs 1356022, 1356034, 1356023, 1356035, 1356042.

Closed by commit : rS300685: Fix a couple of new instances of a false positive Coverity buffer (authored by truckman).

May 25 2016, 4:08 PM
truckman committed rS300686: Fix a couple of Coverity Unintended sign extension sign extension.
Fix a couple of Coverity Unintended sign extension sign extension
May 25 2016, 3:49 PM
truckman committed rS300685: Fix a couple of new instances of a false positive Coverity buffer.
Fix a couple of new instances of a false positive Coverity buffer
May 25 2016, 3:43 PM
truckman updated the diff for D6558: Fix Coverity CIDs 1356022, 1356034, 1356023, 1356035, 1356042.

Clear cdb_storage before reusing it.

May 25 2016, 8:44 AM
truckman retitled D6558: Fix Coverity CIDs 1356022, 1356034, 1356023, 1356035, 1356042 from to Fix Coverity CIDs 1356022, 1356034, 1356023, 1356035, 1356042.
May 25 2016, 8:41 AM
truckman retitled D6557: Fix Coverity CIDs 1356044 and 1356045 Unintended sign extension from to Fix Coverity CIDs 1356044 and 1356045 Unintended sign extension.
May 25 2016, 8:26 AM
truckman committed rS300666: Call closedir() before returning from fetchListFile() to avoid a leak..
Call closedir() before returning from fetchListFile() to avoid a leak.
May 25 2016, 7:43 AM
truckman committed rS300665: Don't leak addrinfo in fetch_bind().
Don't leak addrinfo in fetch_bind()
May 25 2016, 7:40 AM
truckman committed rS300664: Fix Coverity CID 978183 Resource leak in rexec()..
Fix Coverity CID 978183 Resource leak in rexec().
May 25 2016, 7:26 AM
truckman committed rS300662: Fix Coverity CID 1016714 Resource leak in process_file_actions_entry().
Fix Coverity CID 1016714 Resource leak in process_file_actions_entry()
May 25 2016, 7:14 AM
truckman committed rS300660: Fix 1016718 Resource leak..
Fix 1016718 Resource leak.
May 25 2016, 6:56 AM
truckman added inline comments to D6360: Fix acpidump CID 1011278 (Buffer not null terminated) and other issues.
May 25 2016, 5:48 AM
truckman committed rS300649: Fix Coverity CID 1019054 (String not null terminated) in setfacl..
Fix Coverity CID 1019054 (String not null terminated) in setfacl.
May 25 2016, 5:20 AM
truckman committed rS300648: Fix CID 1011370 (Resource leak) in ps..
Fix CID 1011370 (Resource leak) in ps.
May 25 2016, 5:13 AM
truckman retitled D6554: Fix CID 977702 (Resource leak) in ed io.c from to Fix CID 977702 (Resource leak) in ed io.c.
May 25 2016, 4:37 AM
truckman committed rS300643: Close from_fd if malloc() fails to avoid a file descriptor leak..
Close from_fd if malloc() fails to avoid a file descriptor leak.
May 25 2016, 2:51 AM
truckman committed rS300642: Match the descriptions of the \H and \h prompt string sequences to reality..
Match the descriptions of the \H and \h prompt string sequences to reality.
May 25 2016, 2:10 AM
truckman retitled D6552: Another try at fixing Coverity 1008328 in /bin/sh from to Another try at fixing Coverity 1008328 in /bin/sh.
May 25 2016, 2:00 AM