Page MenuHomeFreeBSD

Don't leak addrinfo if ai->ai_addrlen <= minsiz test fails
ClosedPublic

Authored by truckman on Jun 8 2016, 8:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 21, 9:25 AM
Unknown Object (File)
Fri, Nov 21, 6:46 AM
Unknown Object (File)
Fri, Nov 21, 6:45 AM
Unknown Object (File)
Fri, Nov 21, 6:43 AM
Unknown Object (File)
Fri, Nov 21, 6:42 AM
Unknown Object (File)
Wed, Nov 19, 8:57 AM
Unknown Object (File)
Wed, Nov 19, 3:32 AM
Unknown Object (File)
Tue, Nov 11, 5:22 PM
Subscribers

Details

Summary

If the ai->ai_addrlen <= minsiz test fails, then
freeaddrinfo() does not get called to free the memory
just allocated by getaddrinfo(). Fix by moving
ai->ai_addrlen <= minsiz to a separate if block
so that freeaddrinfo() will be called whenever
getaddrinfo() succeeds.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

truckman retitled this revision from to Don't leak addrinfo if ai->ai_addrlen <= minsiz test fails.
truckman updated this object.
truckman edited the test plan for this revision. (Show Details)
truckman added a reviewer: ume.
ume edited edge metadata.

It seems good to me.

This revision is now accepted and ready to land.Jun 8 2016, 9:11 AM
This revision was automatically updated to reflect the committed changes.