HomeFreeBSD

Don't leak addrinfo if ai->ai_addrlen <= minsiz test fails.

Description

Don't leak addrinfo if ai->ai_addrlen <= minsiz test fails.

If the ai->ai_addrlen <= minsiz test fails, then freeaddrinfo()
does not get called to free the memory just allocated by getaddrinfo().
Fix by moving ai->ai_addrlen <= minsiz to a separate nested if
block, and keep freeaddrinfo() in the outer block so that freeaddrinfo()
will be called whenever getaddrinfo() succeeds.

Reported by: Coverity
CID: 1273652
Reviewed by: ume
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D6756

Details

Provenance
truckmanAuthored on
Reviewer
ume
Differential Revision
D6756: Don't leak addrinfo if ai->ai_addrlen <= minsiz test fails
Parents
rS301591: Last few instances of "sentence not on new line".
Branches
Unknown
Tags
Unknown