Page MenuHomeFreeBSD
Differential D6651

keyserv(1): Wrong comparison in load_des()
ClosedPublic
Actions

Authored by pfg on May 30 2016, 7:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 26, 9:56 PM
Unknown Object (File)
Tue, Aug 25, 3:44 PM
Unknown Object (File)
Fri, Aug 21, 6:39 AM
Unknown Object (File)
Tue, Aug 18, 7:46 AM
Unknown Object (File)
Sun, Aug 16, 5:02 PM
Unknown Object (File)
Sat, Aug 15, 8:40 PM
Unknown Object (File)
Fri, Aug 14, 9:50 PM
Unknown Object (File)
Thu, Aug 13, 8:14 PM
View All Files
Subscribers
imp

Details

Reviewers
truckman
ngie
Summary

According to Coverity (CID 1008422), as dlpath is a character array
so the omparson to NULL makes no sense. It appears it is always
assigned to something in the previous "if" so perhaps we should
get rid of it completely.

While here remove redundant bracket as it appears to be the style
exception wrt the rest of the code.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4039
Build 4082: arc lint + arc unit

Event Timeline

pfg updated this revision to Diff 17122.May 30 2016, 7:55 PM
pfg retitled this revision from to keyserv(1): Wrong comparison in load_des().
pfg updated this object.
pfg edited the test plan for this revision. (Show Details)
pfg added reviewers: truckman, ngie.
Herald added a subscriber: imp. · View Herald TranscriptMay 30 2016, 7:55 PM
ngie accepted this revision.May 30 2016, 7:57 PM
ngie edited edge metadata.
This revision is now accepted and ready to land.May 30 2016, 7:57 PM
truckman accepted this revision.Jun 1 2016, 6:21 PM
truckman edited edge metadata.
pfg closed this revision.Jun 1 2016, 6:50 PM

Committed as r301005.
Thanks to the reviewers!

Revision Contents
Changeset List

PathSize
usr.sbin/
keyserv/
9 lines

Diff 17122

View Options

usr.sbin/keyserv/crypt_server.c

Loading...