• Add SATA devpath node decoding
• Fix and rename msg_path_matches -> device_path_matches
• Add boot1 imgpath debug

Further debugging improvements.

Refactor preferred device so that:

1. Its sticky for all requests, this ensures that boot.config is loaded from the same device / pool as loader.efi.
2. Allows UFS only preferred devices to work correctly.

@imp with the latest set of improved debugging we should be able to see what's loading from where.

• Change boot module loader_path -> filepath to better refect its use.
• Switch devinfo_t.devpath to store the full path instead of final node to aid debugging.
• Improve debug and error output.
• Fix DPRINTF for single argument use.
• Refactor msgpath calculation into seperate methods.

Committed as: https://svnweb.freebsd.org/changeset/base/295051

In D5117#108850, @sbruno wrote:

I should have captured r285592 in the MFC of driver version 3.1.0 to stable 10. https://svnweb.freebsd.org/base?view=revision&revision=294061

In D5108#108719, @imp wrote:

When I tested this with a USB drive that had a /boot.config with -h and a SATA SSD with a boot.config with -D in it. The sata was fs0: in the uefi shell , while the usb clocked in with fs1. I get identical boot behavior if I type in fs0:\efi\boot\bootx64.efi and fs1:\efi\boot\bootx64.efi. Both of them are dying during boot because there's no /dev/ada0 to satisfy the /etc/fstab I have on the usb drive. If I pull it out, it goes back to booting correctly.

So it appears that we're now finding the loader.efi, but that at least boot1 is still confused a bit. Perhaps my hack for the /boot.config stuff in there needs to be fixed too, since it clearly is finding the loader.efi.

Anything I can do to help debug this?

Added filepath to try_load debug.

Improved debug output

We have a version of just this but back ported to 10.2 running in production.

In D5108#108651, @imp wrote:

Would this fix 'panic, can't find /boot/loader.efi' messages when I have an EFI system and plug in a USB device that's also bootable. If so, well done dir! That was on my list for next week.

In D5089#108282, @jeffrey.e.pieper_intel.com wrote:

Well Linux changes FC settings through ethtool, so maybe that makes a difference. I'm pretty sure FC in the Linux driver works as expected. I was saying we need to be careful when changing shared code because as it may not get accepted when it goes though our code review internally. Eric may have a different opinion, although Sean's suggestion seems fine to me.

In D5089#108263, @jeffrey.e.pieper_intel.com wrote:

We need to be careful here, as this is shared code. Our Linux drivers use this as well.

Ideally the path / rbx cleanup and the addition of new features such as the boot config support for EFI should be committed separately.

Set advertise = 0 when media = auto

Remove unused changes from bootstrap.h

Just some style nits.

Move fsizep assignment to the end of fsread as requested by tsoome_me.com

All test plan test pass here now under qemu.

Fix lost dmadat definition and assignment and add check for invalid dmadat in fsread.

Compile tested but not completed the test plan yet, will confirm once it's passed.

Fix style(9) nit.

Happy with this from a style perspective, however I haven't tested and this area is not one of my strong points. So for commit I'd say I've only reviewed (in part).

In D1986#105007, @rpokala wrote:

@smh: "Also still some older style(9) comments still not addressed."

Other than the blank line you mentioned, what other style(9) issues are there?

Forgot to reference review in commit r294068.

All good, any reason to update to 3.1.13-k?

Update to head r294041
Convert file_loadraw name param to const fixing compiler warning.

Also still some older style(9) comments still not addressed.