Fix ix advertise value after media change
ClosedPublic
Actions

Authored by smh on Jan 22 2016, 3:13 PM.

Details

Reviewers

erj
sbruno

Group Reviewers

Intel Networking

Commits

rS294578: Fix ix advertise value after media change

Summary

When ifconfig sets media then the values displayed by the advertise_speed
value are invalidated.

Fix this by setting the bits correctly including setting advertise to 0 for media = auto

Test Plan

sysctl dev.ix.0.advertise_speed Should print 0 (auto)
ifconfig ix0 media 1000baseT Should print 3 (100 + 1G)
ifconfig ix0 media 10Gbase-T Should print 7 (100 + 1G + 10G)
ifconfig ix0 media auto Should print 0 (all)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

smh updated this revision to Diff 12596.Jan 22 2016, 3:13 PM

smh retitled this revision from to Fix ix advertise value after media change.

smh updated this object.

smh edited the test plan for this revision. (Show Details)

smh added reviewers: sbruno, erj.

Herald added a reviewer: Intel Networking. · View Herald TranscriptJan 22 2016, 3:13 PM

Herald added a subscriber: imp. · View Herald Transcript

Set advertise = 0 when media = auto

Herald edited edge metadata. · View Herald TranscriptJan 22 2016, 3:44 PM

smh updated this object.Jan 22 2016, 3:55 PM

smh edited the test plan for this revision. (Show Details)

smh edited edge metadata.

sbruno accepted this revision.Jan 22 2016, 3:58 PM

sbruno edited edge metadata.

This revision is now accepted and ready to land.Jan 22 2016, 3:58 PM

Closed by commit rS294578: Fix ix advertise value after media change (authored by smh). · Explain WhyJan 22 2016, 5:03 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

ixgbe/

if_ix.c

14 lines

Diff 12606

View Options

head/sys/dev/ixgbe/if_ix.c

Fix ix advertise value after media changeClosedPublicActions