Page MenuHomeFreeBSD

Fix ix advertise value after media change
ClosedPublic

Authored by smh on Jan 22 2016, 3:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 24, 6:53 PM
Unknown Object (File)
Fri, Dec 20, 3:46 AM
Unknown Object (File)
Fri, Dec 20, 1:36 AM
Unknown Object (File)
Sun, Dec 15, 8:26 PM
Unknown Object (File)
Nov 24 2024, 1:15 AM
Unknown Object (File)
Nov 18 2024, 5:46 PM
Unknown Object (File)
Nov 18 2024, 6:15 AM
Unknown Object (File)
Nov 11 2024, 1:03 AM
Subscribers

Details

Summary

When ifconfig sets media then the values displayed by the advertise_speed
value are invalidated.

Fix this by setting the bits correctly including setting advertise to 0 for media = auto

Test Plan
  1. sysctl dev.ix.0.advertise_speed Should print 0 (auto)
  2. ifconfig ix0 media 1000baseT Should print 3 (100 + 1G)
  3. ifconfig ix0 media 10Gbase-T Should print 7 (100 + 1G + 10G)
  4. ifconfig ix0 media auto Should print 0 (all)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2230
Build 2239: arc lint + arc unit

Event Timeline

smh retitled this revision from to Fix ix advertise value after media change.
smh updated this object.
smh edited the test plan for this revision. (Show Details)
smh added reviewers: sbruno, erj.
smh edited edge metadata.

Set advertise = 0 when media = auto

smh edited the test plan for this revision. (Show Details)
smh edited edge metadata.
sbruno edited edge metadata.
This revision is now accepted and ready to land.Jan 22 2016, 3:58 PM
This revision was automatically updated to reflect the committed changes.