Page MenuHomeFreeBSD

ficl i386 unsigned char output to support efi i386
ClosedPublic

Authored by tsoome on Jan 19 2016, 10:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 15, 9:10 PM
Unknown Object (File)
Mon, Nov 11, 2:46 AM
Unknown Object (File)
Oct 18 2024, 10:45 AM
Unknown Object (File)
Oct 8 2024, 8:12 PM
Unknown Object (File)
Oct 1 2024, 5:17 PM
Unknown Object (File)
Oct 1 2024, 1:39 PM
Unknown Object (File)
Sep 12 2024, 2:00 AM
Unknown Object (File)
Sep 12 2024, 2:00 AM

Details

Summary

apparently the fbsd loader efi is supporting 32bit i386 as well, so similar update as done for amd64 is needed to make it possible for efi_console to recognize and translate box characters on i386 build (unsigned versus signed char passed as int issue).

Im pretty sure the arm variants have the same issue *if* bootforth is used there. The defect itself is manifested as menu frame (box) is not drawn, so it is easy to verify if such type cast is needed - unfortunately I don't have resources to check arm, hopefully someone with access to platform can check...

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tsoome retitled this revision from to ficl i386 unsigned char output to support efi i386.
tsoome updated this object.
tsoome edited the test plan for this revision. (Show Details)
tsoome set the repository for this revision to rS FreeBSD src repository - subversion.
tsoome added subscribers: allanjude, emaste.
emaste added a reviewer: emaste.
This revision is now accepted and ready to land.Jan 19 2016, 3:31 PM
smh edited edge metadata.
dteske edited edge metadata.
This revision was automatically updated to reflect the committed changes.