Page MenuHomeFreeBSD
Differential D4989

Fix EFI UFS caching
ClosedPublic
Actions

Authored by smh on Jan 18 2016, 10:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 7, 10:02 PM
Unknown Object (File)
Nov 24 2024, 1:16 AM
Unknown Object (File)
Oct 1 2024, 1:44 PM
Unknown Object (File)
Sep 27 2024, 3:38 AM
Unknown Object (File)
Sep 27 2024, 2:45 AM
Unknown Object (File)
Sep 26 2024, 11:34 AM
Unknown Object (File)
Sep 26 2024, 11:00 AM
Unknown Object (File)
Sep 24 2024, 5:30 PM
View All Files
Subscribers
imp
tsoome

Details

Reviewers
emaste
andrew
Commits
rS294493: Fix EFI UFS caching
Summary

EFI was mixing caching in two seperate places causing issues when
multiple partitions where tested.

Eliminate this by removing ffstat and refactoring fsread into fsread_size,
adding basic parameter validation.

Also:

  • Enhance some error print outs.
  • Fix compilation under UFS1_ONLY and UFS2_ONLY
  • Use sizeof on parameters instead of structs.
Test Plan

Boot from a UFS image which has 2 UFS partitions:

  1. First bootable, second NOT bootable
  2. First NOT bootable, second bootable

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

smh updated this revision to Diff 12439.Jan 18 2016, 10:37 PM
smh retitled this revision from to Fix EFI UFS caching.
smh updated this object.
smh edited the test plan for this revision. (Show Details)
Herald added a subscriber: imp. · View Herald TranscriptJan 18 2016, 10:37 PM
smh added a reviewer: emaste.Jan 18 2016, 10:41 PM
emaste added a reviewer: andrew.Jan 18 2016, 10:42 PM
smh updated this revision to Diff 12440.Jan 18 2016, 10:43 PM

Fix style(9) nit.

smh added a comment.Jan 18 2016, 11:34 PM

Compile tested but not completed the test plan yet, will confirm once it's passed.

smh updated this revision to Diff 12442.Jan 19 2016, 12:57 AM

Fix lost dmadat definition and assignment and add check for invalid dmadat in fsread.

smh added a comment.Jan 19 2016, 12:58 AM

All test plan test pass here now under qemu.

emaste added a subscriber: tsoome.Jan 19 2016, 5:53 PM
tsoome added inline comments.Jan 19 2016, 6:28 PM
sys/boot/common/ufsread.c
259 ↗(On Diff #12442)

as disk read in while loop below can fail, perhaps move this assignment to the end? it feels a bit wrong to set OUT value so early.

smh updated this revision to Diff 12475.Jan 19 2016, 6:49 PM

Move fsizep assignment to the end of fsread as requested by tsoome_me.com

smh marked an inline comment as done.Jan 19 2016, 6:51 PM
Closed by commit rS294493: Fix EFI UFS caching (authored by smh). · Explain WhyJan 21 2016, 8:59 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
boot/
common/
30 lines
efi/
boot1/
101 lines

Diff 12539

View Options

head/sys/boot/common/ufsread.c

Loading...
View Options

head/sys/boot/efi/boot1/ufs_module.c

Loading...