Differential D32434

The IPv4 address list has enough protection from the network epoch. An IPv4 address is embedded into an ifaddr which is freed via epoch. The in_ifaddrhead is already a CK list. Next step would be to CK-ify the in_addr hash and get rid of the...
ClosedPublic
Actions

Authored by glebius on Oct 10 2021, 2:52 AM.

Details

Reviewers

melifaro

Group Reviewers

network

Commits

rG2144431c1152: Remove in_ifaddr_lock acquisiton to access in_ifaddrhead.

Summary

...rmlock completely.

don't use rmlock(9) for in_ifaddrhead.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Oct 10 2021, 2:52 AM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptOct 10 2021, 2:52 AM

glebius requested review of this revision.Oct 10 2021, 2:52 AM

Harbormaster completed remote builds in B42045: Diff 96589.Oct 10 2021, 2:52 AM

melifaro accepted this revision.Oct 12 2021, 11:15 PM

This revision is now accepted and ready to land.Oct 12 2021, 11:15 PM

Closed by commit rG2144431c1152: Remove in_ifaddr_lock acquisiton to access in_ifaddrhead. (authored by glebius). · Explain WhyOct 13 2021, 5:10 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG2144431c1152: Remove in_ifaddr_lock acquisiton to access in_ifaddrhead..

Revision Contents
Changeset List

Path

Size

sys/

net/

if_stf.c

4 lines

netinet/

6 lines

10 lines

27 lines

6 lines

8 lines

7 lines

4 lines

14 lines

Diff 96830

View Options

sys/net/if_stf.c

View Options

sys/netinet/if_ether.c

View Options

sys/netinet/igmp.c

View Options

sys/netinet/in.c

View Options

sys/netinet/in_mcast.c

View Options

sys/netinet/in_pcb.c

View Options

sys/netinet/in_var.h

View Options

sys/netinet/ip_output.c

View Options

The IPv4 address list has enough protection from the network epoch. An IPv4 address is embedded into an ifaddr which is freed via epoch. The in_ifaddrhead is already a CK list. Next step would be to CK-ify the in_addr hash and get rid of the...ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 96830

sys/net/if_stf.c

sys/netinet/if_ether.c

sys/netinet/igmp.c

sys/netinet/in.c

sys/netinet/in_mcast.c

sys/netinet/in_pcb.c

sys/netinet/in_var.h

sys/netinet/ip_output.c

sys/netinet/raw_ip.c

The IPv4 address list has enough protection from the network epoch. An IPv4 address is embedded into an ifaddr which is freed via epoch. The in_ifaddrhead is already a CK list. Next step would be to CK-ify the in_addr hash and get rid of the...
ClosedPublic
Actions

Revision Contents
Changeset List