Paths

Table of Contentst

Differential D31223

cxgbei: Support for ISO (iSCSI segmentation offload).
ClosedPublic
Actions

Authored by jhb on Jul 19 2021, 10:21 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Aug 25, 10:32 PM

	Unknown Object (File)
	Fri, Aug 21, 3:45 PM

	Unknown Object (File)
	Fri, Aug 21, 7:25 AM

	Unknown Object (File)
	Thu, Aug 20, 8:34 PM

	Unknown Object (File)
	Wed, Aug 19, 3:06 AM

	Unknown Object (File)
	Mon, Aug 17, 4:26 PM

	Unknown Object (File)
	Mon, Aug 17, 4:06 AM

	Unknown Object (File)
	Sat, Aug 15, 8:58 PM

Subscribers

Details

Reviewers

mav
np
trasz

Commits

rG132894ca4beb: cxgbei: Support for ISO (iSCSI segmentation offload).
rG5b27e4b27caa: cxgbei: Support for ISO (iSCSI segmentation offload).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 40538
Build 37427: arc lint + arc unit

Event Timeline

jhb created this revision.Jul 19 2021, 10:21 PM

Herald added subscribers: ae, imp. · View Herald TranscriptJul 19 2021, 10:21 PM

jhb requested review of this revision.Jul 19 2021, 10:21 PM

jhb added a parent revision: D31222: iSCSI: Add support for segmentation offload for hardware offloads..

Harbormaster completed remote builds in B40538: Diff 92440.Jul 19 2021, 10:22 PM

jhb added inline comments.Jul 19 2021, 10:52 PM

sys/dev/cxgbe/cxgbei/icl_cxgbei.c
861	I'm just not sure what header this would go in. It seems like something that would perhaps belong in a common t4_foo.h header?
872	When I tried this setting, it didn't work, so possibly I should just drop this comment.

jhb added inline comments.Jul 29 2021, 9:48 PM

sys/dev/cxgbe/cxgbei/icl_cxgbei.c
861	I've renamed this to `CXGBEI_MAX_ISO_PAYLOAD` and moved it to cxgbei.h.
872	When I tried this setting, it didn't work, so possibly I should just drop this comment. We've since had to debug an issue with this particular value internally and I've changed the expression that goes here. I'll update this patch when the updated version when it's ready.

Some cleanups to PLEN_MAX.
Add a knob to disable ISO.
Disable ISO on T4.

Harbormaster completed remote builds in B40759: Diff 93003.Jul 30 2021, 8:58 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 6 2021, 9:30 PM

Closed by commit rG5b27e4b27caa: cxgbei: Support for ISO (iSCSI segmentation offload). (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG5b27e4b27caa: cxgbei: Support for ISO (iSCSI segmentation offload)..

jhb added a commit: rG132894ca4beb: cxgbei: Support for ISO (iSCSI segmentation offload)..Oct 30 2021, 12:01 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

cxgbe/

1 line

cxgbei/

60 lines

1 line

5 lines

tom/

184 lines

52 lines

Diff 92440

sys/dev/cxgbe/adapter.h

Loading...

sys/dev/cxgbe/cxgbei/icl_cxgbei.c

Loading...

sys/dev/cxgbe/t4_main.c

Loading...

sys/dev/cxgbe/t4_sge.c

Loading...

sys/dev/cxgbe/tom/t4_cpl_io.c

Loading...

sys/dev/cxgbe/tom/t4_tom.h

Loading...