xen/efi: make Xen PV EFI clock optional
ClosedPublic
Actions

Authored by ehem_freebsd_m5p.com on Jul 5 2021, 6:42 PM.

Details

Reviewers

royger
mhorne
julien_xen.org

Commits

rGb2c50bb934fb: xen/efi: make Xen PV EFI clock optional

Summary

The present implementation is only for x86. Other architectures need adjustments for querying presence of EFI.

Xen's EFI support is also quite troublesome on non-x86. This is being
slowly remedied, but until in better shape the EFI clock functionality
should be disabled.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 40323
Build 37212: arc lint + arc unit

Event Timeline

ehem_freebsd_m5p.com created this revision.Jul 5 2021, 6:42 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 5 2021, 6:42 PM

ehem_freebsd_m5p.com requested review of this revision.Jul 5 2021, 6:42 PM

Harbormaster completed remote builds in B40323: Diff 91821.Jul 5 2021, 6:42 PM

ehem_freebsd_m5p.com added a child revision: D30950: xen/arm64: enable arm64 Xen configuration.Jul 5 2021, 6:44 PM

I was taking some glances at making this cross-architecture, but the simpler short-term approach is to make this !arm64. Plus for that matter, Xen's EFI/ACPI support on arm64 isn't yet in particularly good shape.

Another alternative would be to have this depend on xentimer, but I've got no idea whether that would be correct (in fact I was under the impression they're quite distinct, so doing that would be an ugly hack).

Ideal solution would be to fix D28619. This though requires merging "bootmethod" from x86 with "arm64_bus_method" from ARM64.

Thing is bootmethod is a string, arm64_bus_method is an enum. The enum seems to make more sense. I'm though curious why the somewhat similar vm_guest variable is declared as an int, even though its values are declared as enums.

Testing confirmed making pvefi.c depend on xentimer works, but I'm unsure whether that is correct.

ehem_freebsd_m5p.com mentioned this in D31955: sys: unify boot/firmware variables.Sep 14 2021, 2:06 AM

I'm marking D31065 as abandoned as D31955 fixes the root cause. D31065 could be resurrected if appropriate, but somehow I don't expect that to happen.

ehem_freebsd_m5p.com removed a child revision: D30950: xen/arm64: enable arm64 Xen configuration.Sep 14 2021, 2:09 AM

ehem_freebsd_m5p.com retitled this revision from xen/efi: disable PV EFI clock on non-x86 to xen/efi: make Xen PV EFI clock optional.May 13 2022, 2:43 AM

ehem_freebsd_m5p.com edited the summary of this revision. (Show Details)

ehem_freebsd_m5p.com changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.

Bringing this back in as D31955 has been stuck. Longer term D31955 is better, just this has a better shot at making 14.0.

Harbormaster completed remote builds in B45561: Diff 105935.May 13 2022, 3:02 AM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 14 2023, 2:01 PM

Closed by commit rGb2c50bb934fb: xen/efi: make Xen PV EFI clock optional (authored by ehem_freebsd_m5p.com, committed by royger). · Explain Why

This revision was automatically updated to reflect the committed changes.

royger added a commit: rGb2c50bb934fb: xen/efi: make Xen PV EFI clock optional.