xen/boot: allow specifying boot method when booted from Xen
ClosedPublic
Actions

Authored by royger on Feb 12 2021, 4:00 PM.

Details

Reviewers

kib
jhb

Commits

rGa2495c36678c: xen/boot: allow specifying boot method when booted from Xen

Summary

Allow setting the bootmethod variable from the Xen PVH entry point, in
order to be able to correctly set the underlying firmware mode when
booted as a dom0.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

royger created this revision.Feb 12 2021, 4:00 PM

Herald added subscribers: rpokala, imp. · View Herald TranscriptFeb 12 2021, 4:00 PM

royger requested review of this revision.Feb 12 2021, 4:00 PM

Harbormaster completed remote builds in B36934: Diff 83770.Feb 12 2021, 4:00 PM

kib added inline comments.Feb 16 2021, 9:38 AM

sys/x86/xen/pv.c
114	I do not see why the declaration is not provided by md_var.h

kib added inline comments.Feb 16 2021, 9:39 AM

sys/amd64/amd64/machdep.c
1171–1172	May be put both the var and sysctl into x86/x86/cpu_machdep.c, so that they do not duplicate. Then you would need to copy "BIOS" on i386 boot as well.

Move bootmethod definition to x86/cpu_machdep.c.
Declare it in md_var.h.

Harbormaster completed remote builds in B37045: Diff 83995.Feb 16 2021, 10:30 AM

kib added inline comments.Feb 16 2021, 11:08 AM

sys/amd64/include/md_var.h
58 ↗	(On Diff #83995)	I wasn't precise enough, sorry. I believe that you should put the declaration into x86/include/x86_var.h which is included by each md_var.h.
sys/x86/xen/pv.c
114	Is this still needed?