xen/boot: allow specifying boot method when booted from Xen
ClosedPublic
Actions

Authored by royger on Fri, Feb 12, 4:00 PM.

Details

Reviewers

kib
jhb

Commits

R10:a2495c36678c: xen/boot: allow specifying boot method when booted from Xen

Summary

Allow setting the bootmethod variable from the Xen PVH entry point, in
order to be able to correctly set the underlying firmware mode when
booted as a dom0.

Diff Detail

Repository

R10 FreeBSD src repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

royger created this revision.Fri, Feb 12, 4:00 PM

Herald added subscribers: rpokala, imp. · View Herald TranscriptFri, Feb 12, 4:00 PM

royger requested review of this revision.Fri, Feb 12, 4:00 PM

Harbormaster completed remote builds in B36934: Diff 83770.Fri, Feb 12, 4:00 PM

kib added inline comments.Tue, Feb 16, 9:38 AM

sys/x86/xen/pv.c
113	I do not see why the declaration is not provided by md_var.h

kib added inline comments.Tue, Feb 16, 9:39 AM

sys/amd64/amd64/machdep.c
1171–1172	May be put both the var and sysctl into x86/x86/cpu_machdep.c, so that they do not duplicate. Then you would need to copy "BIOS" on i386 boot as well.

Move bootmethod definition to x86/cpu_machdep.c.
Declare it in md_var.h.

Harbormaster completed remote builds in B37045: Diff 83995.Tue, Feb 16, 10:30 AM

kib added inline comments.Tue, Feb 16, 11:08 AM

sys/amd64/include/md_var.h
58 ↗	(On Diff #83995)	I wasn't precise enough, sorry. I believe that you should put the declaration into x86/include/x86_var.h which is included by each md_var.h.
sys/x86/xen/pv.c
113	Is this still needed?