Page MenuHomeFreeBSD

xen/boot: allow specifying boot method when booted from Xen
ClosedPublic

Authored by royger on Fri, Feb 12, 4:00 PM.

Details

Summary

Allow setting the bootmethod variable from the Xen PVH entry point, in
order to be able to correctly set the underlying firmware mode when
booted as a dom0.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sys/x86/xen/pv.c
113

I do not see why the declaration is not provided by md_var.h

sys/amd64/amd64/machdep.c
1171–1172

May be put both the var and sysctl into x86/x86/cpu_machdep.c, so that they do not duplicate. Then you would need to copy "BIOS" on i386 boot as well.

  • Move bootmethod definition to x86/cpu_machdep.c.
  • Declare it in md_var.h.
sys/amd64/include/md_var.h
58 ↗(On Diff #83995)

I wasn't precise enough, sorry. I believe that you should put the declaration into x86/include/x86_var.h which is included by each md_var.h.

sys/x86/xen/pv.c
113

Is this still needed?

  • Move bootmethod declaration to x86_var.h.
  • Remove extern declaration from pv.c.
This revision is now accepted and ready to land.Tue, Feb 16, 11:49 AM