Page MenuHomeFreeBSD
Differential D29433

bhyve: change vq_getchain to return iovecs in both directions
ClosedPublic
Actions

Authored by khng on Mar 26 2021, 5:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 21, 8:12 PM
Unknown Object (File)
Mon, Apr 20, 1:35 PM
Unknown Object (File)
Mon, Apr 20, 5:21 AM
Unknown Object (File)
Thu, Apr 16, 7:28 AM
Unknown Object (File)
Wed, Apr 15, 5:20 AM
Unknown Object (File)
Mon, Apr 13, 6:18 AM
Unknown Object (File)
Mon, Apr 6, 5:11 PM
Unknown Object (File)
Mon, Apr 6, 9:05 AM
View All Files
Subscribers
afedorov
bcran
imp
rgrimes

Details

Reviewers
grehan
afedorov
philip
lwhsu
Group Reviewers
bhyve
Commits
rG3fc8a816d9a3: bhyve: change vq_getchain to return iovecs in both directions
rGb013912772ec: bhyve: change vq_getchain to return iovecs in both directions
Summary

bhyve: change vq_getchain to return read and write iovecs

The old prototype requires callers to inspect flags of each descriptors
to get the starting position of host-to-guest iovecs.

vq_getchain() is changed to return a virtio request with both the
guest-to-host iovecs and host-to-guest iovecs recorded instead.
Callers can obtain the host-to-guest iovecs directly.

Sponsored by: The FreeBSD Foundation
MFC after: 3 weeks

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

khng created this revision.Mar 26 2021, 5:25 PM
Herald added a reviewer: bhyve. · View Herald TranscriptMar 26 2021, 5:25 PM
Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript
khng requested review of this revision.Mar 26 2021, 5:25 PM
Harbormaster completed remote builds in B38090: Diff 86354.Mar 26 2021, 5:25 PM
khng updated this revision to Diff 86355.Mar 26 2021, 5:45 PM
  • Fixed loopy check fallout out when num of descs are equal to maximum number
  • No need to use memset in vq_getchain
Harbormaster completed remote builds in B38091: Diff 86355.Mar 26 2021, 5:45 PM
afedorov added a subscriber: afedorov.Mar 27 2021, 8:10 AM
afedorov added inline comments.
usr.sbin/bhyve/pci_virtio_9p.c
200–201

It looks like the flags[] array is no longer used.

215

Debug output doesn't make sense anymore.

khng updated this revision to Diff 86379.Mar 27 2021, 8:33 AM
  • Remove unused flags from pci_vt9p_notify
Harbormaster completed remote builds in B38106: Diff 86379.Mar 27 2021, 8:33 AM
khng marked 2 inline comments as done.Mar 27 2021, 8:33 AM
afedorov accepted this revision.Mar 28 2021, 8:59 AM
afedorov added inline comments.
usr.sbin/bhyve/pci_virtio_scsi.c
623–624

enqueuedvi -> enqueued

This revision is now accepted and ready to land.Mar 28 2021, 8:59 AM
khng added a reviewer: philip.Mar 28 2021, 9:00 AM
khng added a reviewer: lwhsu.Mar 28 2021, 9:02 AM
khng edited the summary of this revision. (Show Details)Mar 28 2021, 3:57 PM
khng retitled this revision from bhyve: vq_getchain returns read iovecs and write iovecs to bhyve: change vq_getchain to return iovecs in both directions.Mar 29 2021, 5:57 PM
khng updated this revision to Diff 86513.Mar 29 2021, 5:59 PM
khng marked an inline comment as done.

Refactor the prototype to match vq_ring_enqueue_segments in sys/dev/virtio/virtqueue.c.

This revision now requires review to proceed.Mar 29 2021, 5:59 PM
Harbormaster completed remote builds in B38164: Diff 86513.Mar 29 2021, 5:59 PM
khng added a comment.Mar 29 2021, 6:02 PM

@afedorov I would like to have some comments on this again.

philip added inline comments.Mar 30 2021, 12:59 AM
usr.sbin/bhyve/pci_virtio_block.c
348

The previous comment inside the loop (deleted lines 348-354 in this diff) was a little clearer. I agree that the assertion should be outside the loop but the comment could be a little clearer. To a casual reader, the assertion is inverted.

usr.sbin/bhyve/virtio.c
273

It would look very slightly neater to initialise this further down, rather than where it's declared. None of the other stack variables are initialised at the top of this function.

282

E.g. initialise req = { 0 }; here.

khng updated this revision to Diff 86537.Mar 30 2021, 2:18 AM

Style.

Harbormaster completed remote builds in B38172: Diff 86537.Mar 30 2021, 2:19 AM
philip accepted this revision.Mar 30 2021, 2:48 AM

Great! Thank you.

Approved by: philip (mentor)

This revision is now accepted and ready to land.Mar 30 2021, 2:48 AM
afedorov accepted this revision.Mar 30 2021, 5:06 AM
afedorov added inline comments.
usr.sbin/bhyve/virtio.c
217–219

“vs” argument is unused.

khng marked 2 inline comments as done.Mar 30 2021, 7:55 AM
Closed by commit rGb013912772ec: bhyve: change vq_getchain to return iovecs in both directions (authored by khng). · Explain WhyMar 30 2021, 8:48 AM
This revision was automatically updated to reflect the committed changes.
khng added a commit: rGb013912772ec: bhyve: change vq_getchain to return iovecs in both directions.
khng added a commit: rG3fc8a816d9a3: bhyve: change vq_getchain to return iovecs in both directions.Aug 12 2021, 6:46 AM

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
22 lines
25 lines
20 lines
12 lines
6 lines
34 lines
16 lines
36 lines

Diff 86540

View Options

usr.sbin/bhyve/pci_virtio_9p.c

Loading...
View Options

usr.sbin/bhyve/pci_virtio_block.c

Loading...
View Options

usr.sbin/bhyve/pci_virtio_console.c

Loading...
View Options

usr.sbin/bhyve/pci_virtio_net.c

Loading...
View Options

usr.sbin/bhyve/pci_virtio_rnd.c

Loading...
View Options

usr.sbin/bhyve/pci_virtio_scsi.c

Loading...
View Options

usr.sbin/bhyve/virtio.h

Loading...
View Options

usr.sbin/bhyve/virtio.c

Loading...