Use new SACK Recovery (RFC6675) pipe calculation with PRR
ClosedPublic
Actions

Authored by rscheff on Feb 20 2021, 5:25 PM.

Details

Reviewers

kbowling
tuexen
jtl
rrs
thj
rgrimes

Group Reviewers

transport

Commits

rG32ed0ef06b83: PRR: use accurate rfc6675_pipe when enabled
rGa8e431e1537d: PRR: use accurate rfc6675_pipe when enabled

Summary

PRR code preceeds the availability of the updated and recommended
calculation from RFC6675 for arriving at the current pipe (bytes
in flight).

If sysctl net.inet.tcp.rfc6675_pipe is enabled, use that method.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 37218
Build 34107: arc lint + arc unit

Event Timeline

rscheff created this revision.Feb 20 2021, 5:25 PM

Herald added a reviewer: transport. · View Herald TranscriptFeb 20 2021, 5:25 PM

Herald added subscribers: Contributor Reviews (src), melifaro, imp. · View Herald Transcript

rscheff requested review of this revision.Feb 20 2021, 5:25 PM

Harbormaster completed remote builds in B37218: Diff 84333.Feb 20 2021, 5:26 PM

rscheff edited the summary of this revision. (Show Details)Feb 20 2021, 5:28 PM

rscheff added reviewers: kbowling, tuexen, jtl, rrs, thj, rgrimes.

tuexen accepted this revision.Feb 20 2021, 5:35 PM

This revision is now accepted and ready to land.Feb 20 2021, 5:35 PM

Closed by commit rGa8e431e1537d: PRR: use accurate rfc6675_pipe when enabled (authored by rscheff). · Explain WhyFeb 20 2021, 7:23 PM

This revision was automatically updated to reflect the committed changes.

rscheff added a commit: rGa8e431e1537d: PRR: use accurate rfc6675_pipe when enabled.

rscheff added a commit: rG32ed0ef06b83: PRR: use accurate rfc6675_pipe when enabled.Feb 28 2021, 8:07 AM

rscheff mentioned this in rGb8ffda0a37e1: tcp: various improvements and fixes to PRR.Mar 4 2021, 12:01 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_input.c

12 lines

Diff 84333

View Options

Use new SACK Recovery (RFC6675) pipe calculation with PRRClosedPublicActions