Differential D23518

epoch support for taskqueues [2]
ClosedPublic
Actions

Authored by glebius on Feb 5 2020, 5:52 PM.

Tags

None

Referenced Files

	F171493932: D23518.diff
	Fri, Sep 11, 11:18 AM

	F171477353: D23518.diff
	Fri, Sep 11, 8:30 AM

	Unknown Object (File)
	Thu, Sep 10, 1:56 AM

	Unknown Object (File)
	Wed, Sep 9, 2:51 AM

	Unknown Object (File)
	Mon, Sep 7, 6:04 PM

	Unknown Object (File)
	Mon, Sep 7, 2:06 AM

	Unknown Object (File)
	Mon, Sep 7, 2:00 AM

	Unknown Object (File)
	Mon, Sep 7, 1:56 AM

Subscribers

Details

Reviewers

gallatin
kib
bz
melifaro
manu
np
olivier
shurd
• hselasky
jeff

Group Reviewers

network
iflib

Commits

rS357772: Use NET_TASK_INIT() and NET_GROUPTASK_INIT() for drivers that process
rS357771: Add flag to struct task to mark the task as requiring network epoch.

Summary

[this is second invocation of D23408]

Add optional epoch to struct task and struct gtask. When processing a taskqueue and a task has associated epoch, then enter for duration of the task. If consecutive tasks belong to the same epoch, batch them.

Use NET_TASK_INIT() and NET_GROUPTASK_INIT() for drivers that process incoming packets in taskqueue context.

Add a temporary compatibility hack to ease transition to new ABI for people who have port modules (e.g. nvidia.ko).

https://github.com/glebius/FreeBSD/commits/taskq-epoch

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29185
Build 27117: arc lint + arc unit

Event Timeline

glebius created this revision.Feb 5 2020, 5:52 PM

Herald added a reviewer: iflib. · View Herald TranscriptFeb 5 2020, 5:52 PM

Harbormaster completed remote builds in B29185: Diff 67820.Feb 5 2020, 5:52 PM

glebius retitled this revision from Summary: epoch support for taskqueues [2] to epoch support for taskqueues [2].Feb 5 2020, 5:52 PM

glebius edited the summary of this revision. (Show Details)

glebius mentioned this in D23408: epoch support for taskqueues.Feb 5 2020, 5:58 PM

• hselasky added inline comments.Feb 7 2020, 9:22 AM

sys/sys/taskqueue.h
113	Should you add: .ta_epoch = NULL Even if that is implicit?

glebius added inline comments.Feb 10 2020, 7:02 PM

sys/sys/taskqueue.h
113	I'd rather remove .ta_pending = 0 assignment, instead. The whole idea behind the C99 sparse initializers was to make it possible to change structure definition without necessity to touch every initializer. Explicit zeroing of every field brings functionality down to the level of C90 initializers.

I'm good with this change.

sys/sys/taskqueue.h
113	I'm fine with that.

Convert pointer in struct task to a flag.

Harbormaster completed remote builds in B29284: Diff 68101.Feb 10 2020, 11:56 PM

jeff accepted this revision.Feb 11 2020, 2:11 AM

jeff added inline comments.

sys/sys/_task.h
65–66	I would redefine these to be identical type widths to task. It should be ABI compatible with just more wasted space if I am reading it correctly.

• hselasky accepted this revision.Feb 11 2020, 8:31 AM

• hselasky added inline comments.

sys/sys/_task.h
54	In big endian machines this will be byte-swapped for binary compatibility (just a FYI) uint16_t ta_priority:8; uint16_t ta_flags:8; --HPS

• hselasky added inline comments.Feb 11 2020, 9:38 AM

sys/kern/subr_gtaskqueue.c
365	in_net_epoch needs update! It is currently only set once.
sys/kern/subr_taskqueue.c
469	Where are you updating in_net_epoch ?

Add flag to struct task to mark the task as requiring network epoch.
Use NET_TASK_INIT() and NET_GROUPTASK_INIT() for drivers that process
Revert "Temporarily force IFF_NEEDSEPOCH until drivers have been resolved."

Harbormaster completed remote builds in B29297: Diff 68127.Feb 11 2020, 6:10 PM

• hselasky accepted this revision.Feb 11 2020, 6:22 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 11 2020, 6:48 PM

Closed by commit rS357771: Add flag to struct task to mark the task as requiring network epoch. (authored by glebius). · Explain Why

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rS357771: Add flag to struct task to mark the task as requiring network epoch..

glebius added a commit: rS357772: Use NET_TASK_INIT() and NET_GROUPTASK_INIT() for drivers that process.Feb 12 2020, 6:44 PM

Revision Contents
Changeset List

Path

Size

4 lines

sys/

dev/

al_eth/

2 lines

alc/

2 lines

ale/

2 lines

ath/

2 lines

3 lines

bge/

5 lines

bwn/

2 lines

bxe/

2 lines

cas/

5 lines

ena/

2 lines

malo/

2 lines

mwl/

2 lines

netmap/

7 lines

nfe/

2 lines

qlxgbe/

2 lines

re/

8 lines

rt/

2 lines

smc/

2 lines

virtio/

network/

2 lines

vnic/

4 lines

vr/

2 lines

wtap/

2 lines

xl/

2 lines

kern/

subr_gtaskqueue.c

16 lines

subr_taskqueue.c

16 lines

net/

7 lines

sys/

4 lines

4 lines

13 lines

2 lines

13 lines

Diff 67820

UPDATING

Loading...

sys/dev/al_eth/al_eth.c

Loading...

sys/dev/alc/if_alc.c

Loading...

sys/dev/ale/if_ale.c

Loading...

sys/dev/ath/if_ath.c

Loading...

sys/dev/ath/if_ath_rx.c

Loading...

sys/dev/bge/if_bge.c

Loading...

sys/dev/bwn/if_bwn.c

Loading...

sys/dev/bxe/bxe.c

Loading...

sys/dev/cas/if_cas.c

Loading...

sys/dev/ena/ena.c

Loading...

sys/dev/malo/if_malo.c

Loading...

sys/dev/mwl/if_mwl.c

Loading...

sys/dev/netmap/if_ptnet.c

Loading...

sys/dev/nfe/if_nfe.c

Loading...

sys/dev/qlxgbe/ql_os.c

Loading...

sys/dev/re/if_re.c

Loading...

sys/dev/rt/if_rt.c

Loading...

sys/dev/smc/if_smc.c

Loading...

sys/dev/virtio/network/if_vtnet.c

Loading...

sys/dev/vnic/nicvf_queues.c

Loading...

sys/dev/vr/if_vr.c

Loading...

sys/dev/wtap/if_wtap.c

Loading...

sys/dev/xl/if_xl.c

Loading...

sys/kern/subr_gtaskqueue.c

Loading...

sys/kern/subr_taskqueue.c

Loading...

sys/net/iflib.c

Loading...

sys/sys/_task.h

Loading...

sys/sys/epoch.h

Loading...

sys/sys/gtaskqueue.h

Loading...

sys/sys/param.h

Loading...

sys/sys/taskqueue.h

Loading...