Page MenuHomeFreeBSD
Differential D60551

man: Link mgb.4 to if_mgb.4
ClosedPublic
Actions

Authored by otis on Fri, Oct 9, 7:56 PM.
Tags
None
Referenced Files
F175519528: D60551.id189291.diff
Sun, Oct 11, 10:10 AM
F175502398: D60551.id189291.diff
Sun, Oct 11, 7:22 AM
F175486961: D60551.id189350.diff
Sun, Oct 11, 5:13 AM
F175486935: D60551.id189419.diff
Sun, Oct 11, 5:12 AM
F175486931: D60551.id189379.diff
Sun, Oct 11, 5:12 AM
F175409321: D60551.id189291.diff
Sat, Oct 10, 4:06 PM
F175408718: D60551.id189350.diff
Sat, Oct 10, 4:00 PM
F175408698: D60551.id189358.diff
Sat, Oct 10, 4:00 PM
View All 18 Files
Subscribers
imp
ngie

Details

Reviewers
ziaee
emaste
Group Reviewers
manpages
Commits
rG2d935a1e93af: man.4: Create if_mgb.4 symlink on supported architectures only.
rG05c49e2aa643: man: Link mgb.4 to if_mgb.4
Summary

For consistency, create a symbolic link from mgb.4 to also
if_mgb.4

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 77917
Build 74800: arc lint + arc unit

Event Timeline

otis created this revision.Fri, Oct 9, 7:56 PM
Herald added a subscriber: imp. · View Herald TranscriptFri, Oct 9, 7:56 PM
otis requested review of this revision.Fri, Oct 9, 7:56 PM
Harbormaster completed remote builds in B77917: Diff 189291.Fri, Oct 9, 7:56 PM
emaste accepted this revision.Fri, Oct 9, 8:13 PM
This revision is now accepted and ready to land.Fri, Oct 9, 8:13 PM
ziaee accepted this revision.Sat, Oct 10, 12:25 AM

Thanks for doing this!

Closed by commit rG05c49e2aa643: man: Link mgb.4 to if_mgb.4 (authored by otis). · Explain WhySat, Oct 10, 11:58 AM
This revision was automatically updated to reflect the committed changes.
otis added a commit: rG05c49e2aa643: man: Link mgb.4 to if_mgb.4.
otis reopened this revision.Sat, Oct 10, 1:33 PM
otis updated this revision to Diff 189358.Sat, Oct 10, 1:33 PM

Create if_mgb.4 symlink on supported architecures only.

Harbormaster completed remote builds in B77959: Diff 189358.Sat, Oct 10, 1:34 PM
ziaee added a comment.Sat, Oct 10, 2:04 PM

If mgb.4 only works on x86, the way to specify that in the manual is to add it to line 25 of mgb.4, like this:

.Dt MGB 4 amd64
share/man/man4/Makefile
799–801

I think you'd actually leave it here, and do it like this, this seems like how the others are done, e.g. bxe.4

956

(except sorted and tabbed and everything)

otis updated this revision to Diff 189379.Sat, Oct 10, 6:22 PM

Address review notes.

Harbormaster completed remote builds in B77970: Diff 189379.Sat, Oct 10, 6:22 PM
otis marked 2 inline comments as done.Sat, Oct 10, 6:22 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sat, Oct 10, 9:57 PM
Closed by commit rG2d935a1e93af: man.4: Create if_mgb.4 symlink on supported architectures only. (authored by otis). · Explain Why
This revision was automatically updated to reflect the committed changes.
otis added a commit: rG2d935a1e93af: man.4: Create if_mgb.4 symlink on supported architectures only..
emaste added a comment.Sat, Oct 10, 10:12 PM

There's no reason for mgb to be x86-only

ngie added a subscriber: ngie.Sat, Oct 10, 10:18 PM
In D60551#1389563, @emaste wrote:

There's no reason for mgb to be x86-only

The manpage matches the kernel module integration, though *shrugs*.

Revision Contents
Changeset List

PathSize
share/
man/
man4/
1 line

Diff 189291

View Options

share/man/man4/Makefile

Loading...