Page MenuHomeFreeBSD
Differential D60128

sound: Convert the SD_F_BUSY cv to an sx
Needs ReviewPublic
Actions

Authored by christos on Tue, Sep 29, 1:19 PM.
Tags
None
Referenced Files
F174876212: D60128.id188001.diff
Tue, Oct 6, 5:23 PM
Unknown Object (File)
Mon, Oct 5, 11:38 PM
Unknown Object (File)
Mon, Oct 5, 10:28 PM
Unknown Object (File)
Mon, Oct 5, 9:04 AM
Unknown Object (File)
Sun, Oct 4, 5:46 PM
Unknown Object (File)
Sun, Oct 4, 7:54 AM
Unknown Object (File)
Sun, Oct 4, 2:27 AM
Unknown Object (File)
Sat, Oct 3, 3:32 PM
View All 21 Files
Subscribers
imp

Details

Reviewers
markj
emaste
kib
Summary

The device busy flag was essentially a custom sleepable lock, which was
invisible to WITNESS. Replace it with an sx lock. This simplifies and
removes some of the PCM macros, and gives us WITNESS coverage. PCM_LOCK
stays for the paths that need a non-sleepable lock.

Name both locks after what they are rather than after the device unit,
so they are distinguishable in WITNESS.

No functional change intended.

MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 77454
Build 74337: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pci/
10 lines
pcm/
4 lines
90 lines
12 lines
4 lines
4 lines
57 lines
24 lines
58 lines
12 lines

Diff 188001

View Options

sys/dev/sound/pci/es137x.c

Loading...
View Options

sys/dev/sound/pcm/channel.c

Loading...
View Options

sys/dev/sound/pcm/dsp.c

Loading...
View Options

sys/dev/sound/pcm/feeder_eq.c

Loading...
View Options

sys/dev/sound/pcm/feeder_rate.c

Loading...
View Options

sys/dev/sound/pcm/mixer.c

Loading...
View Options

sys/dev/sound/pcm/sound.h

Loading...
View Options

sys/dev/sound/pcm/sound.c

Loading...
View Options

sys/dev/sound/pcm/vchan.c

Loading...
View Options

sys/dev/sound/sndstat.c

Loading...