sound: Protect channels.pcm.opened with the sx alone
Needs ReviewPublic
Actions

Authored by christos on Fri, Oct 9, 9:41 AM.

Tags

None

Referenced Files

	F175716428: D60513.id.diff
	Mon, Oct 12, 6:05 PM

	Unknown Object (File)
	Mon, Oct 12, 12:49 PM

	Unknown Object (File)
	Mon, Oct 12, 11:53 AM

	Unknown Object (File)
	Mon, Oct 12, 10:51 AM

	Unknown Object (File)
	Mon, Oct 12, 8:33 AM

	Unknown Object (File)
	Sun, Oct 11, 1:30 PM

	Unknown Object (File)
	Sun, Oct 11, 7:15 AM

	Unknown Object (File)
	Sat, Oct 10, 10:29 PM

View All 20 Files

Subscribers

imp

Details

Reviewers

markj
emaste
kib

Summary

This list is initialized in pcm_init() and only accessed by dsp_open()
and dsp_close(), and we are under sx already, so the PCM_LOCK does not
add anything.

PCM_LOCK is also held around playcount/reccount reads, which are also
under sx now.

MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77900
Build 74783: arc lint + arc unit

Event Timeline

christos created this revision.Fri, Oct 9, 9:41 AM

Herald added a subscriber: imp. · View Herald TranscriptFri, Oct 9, 9:41 AM

christos requested review of this revision.Fri, Oct 9, 9:41 AM

Harbormaster completed remote builds in B77900: Diff 189180.Fri, Oct 9, 9:41 AM

christos added a parent revision: D60512: sound: Stop taking PCM_LOCK to create and destroy channels.Fri, Oct 9, 9:41 AM

christos added a child revision: D60514: sound: Retire PCM_LOCK in SNDCTL_DSP_GETCAPS.Fri, Oct 9, 10:11 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

dsp.c

10 lines

Diff 189180

View Options

sound: Protect channels.pcm.opened with the sx aloneNeeds ReviewPublicActions