Differential D60514

sound: Retire PCM_LOCK in SNDCTL_DSP_GETCAPS
Needs ReviewPublic
Actions

Authored by christos on Fri, Oct 9, 10:11 AM.

Project Tags

None

Referenced Files

None

Subscribers

imp

Details

Reviewers

markj
emaste
kib

Summary

The handler reads the device flags, for which there is no consistent
reader lock as of now. It also checks whether CHN_F_VIRTUAL is set. That
flag is set once in vchan_init() when the channel is created, and never
cleared. Neither read needs a lock.

MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77901
Build 74784: arc lint + arc unit

Event Timeline

christos created this revision.Fri, Oct 9, 10:11 AM

Herald added a subscriber: imp. · View Herald TranscriptFri, Oct 9, 10:11 AM

christos requested review of this revision.Fri, Oct 9, 10:11 AM

Harbormaster completed remote builds in B77901: Diff 189181.Fri, Oct 9, 10:11 AM

christos added a child revision: D60515: sound: Retire PCM_LOCK in sound_oss_card_info().Fri, Oct 9, 10:11 AM

christos added a parent revision: D60513: sound: Protect channels.pcm.opened with the sx alone.Fri, Oct 9, 10:11 AM

Why not use the busy lock to synchronize? It seems rather fragile this way.

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

dsp.c

2 lines

Diff 189181

View Options

sound: Retire PCM_LOCK in SNDCTL_DSP_GETCAPSNeeds ReviewPublicActions