sound: Retire pcm_channel->sleeping
AcceptedPublic
Actions

Authored by christos on Tue, Sep 29, 12:26 PM.

Details

Reviewers

markj
emaste
kib

Summary

This field and the pause_sbt() in pcm_shutdownchans() are redundant now,
because pcm_shutdownchans() (previously part of pcm_killchans()) is now
only responsible for waking up and stopping the channel, and
destroy_dev() will not return until the threads have returned from their
cdev methods.

MFC after: 1 week
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77439
Build 74322: arc lint + arc unit

Event Timeline

christos created this revision.Tue, Sep 29, 12:26 PM

Herald added a subscriber: imp. · View Herald TranscriptTue, Sep 29, 12:26 PM

christos requested review of this revision.Tue, Sep 29, 12:26 PM

Harbormaster completed remote builds in B77439: Diff 187986.Tue, Sep 29, 12:26 PM

christos added a parent revision: D60120: sound: Drain the dsp cdev before freeing resources.Tue, Sep 29, 12:26 PM

christos added a child revision: D60128: sound: Convert the SD_F_BUSY cv to an sx.Fri, Oct 9, 9:29 AM

markj accepted this revision.Tue, Oct 20, 1:34 PM

markj added inline comments.

sys/dev/sound/pcm/sound.c
159	Seems ok, but the comments from the previous revision still apply, i.e., the list traversal is unlocked, and I suspect we should not skip idle channels like this.

This revision is now accepted and ready to land.Tue, Oct 20, 1:34 PM