Differential D60517

sound: Document the locking protocol
Needs ReviewPublic
Actions

Authored by christos on Fri, Oct 9, 11:07 AM.

Project Tags

None

Referenced Files

None

Subscribers

imp

Details

Reviewers

markj
emaste
kib

Summary

MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77904
Build 74787: arc lint + arc unit

Event Timeline

christos created this revision.Fri, Oct 9, 11:07 AM

Herald added a subscriber: imp. · View Herald TranscriptFri, Oct 9, 11:07 AM

christos requested review of this revision.Fri, Oct 9, 11:07 AM

Harbormaster completed remote builds in B77904: Diff 189221.Fri, Oct 9, 11:07 AM

christos added a parent revision: D60515: sound: Retire PCM_LOCK in sound_oss_card_info().Fri, Oct 9, 11:08 AM

christos added a child revision: D60518: sound: Busy the device in mixer_oss_mixerinfo().Fri, Oct 9, 11:22 AM

Seems ok. It would be nicer to annotate individual fields like we do for other structures, see struct vm_page for instance.

sys/dev/sound/pcm/sound.h
164	It's also used for synchronizing with device teardown, I believe.
182	Isn't it illegal to hold multiple channel locks at the same time? If not, then it would be nice to rework chn_resizebuf() to avoid dropping the (child) channel lock part-way through. BTW, that function still has some bugs in that it doesn't properly roll back state after an error, e.g., the CHN_F_HAS_SIZE flag.

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

sound.h

32 lines

Diff 189221

View Options

sound: Document the locking protocolNeeds ReviewPublicActions