sound: Do not take PCM_LOCK just to busy the device
Needs ReviewPublic
Actions

Authored by christos on Tue, Sep 29, 1:19 PM.

Details

Reviewers

markj
emaste
kib

Summary

PCM_WAIT(), PCM_ACQUIRE() and PCM_RELEASE() all assert that PCM_LOCK is
held, which forced callers to take the mutex just to use the macros.
Convert them to PCM_ACQUIRE_QUICK()/PCM_RELEASE_QUICK() and keep
PCM_LOCK only where it actually guards something.

No functional change intended.

MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77453
Build 74336: arc lint + arc unit

Event Timeline

christos created this revision.Tue, Sep 29, 1:19 PM

Herald added a subscriber: imp. · View Herald TranscriptTue, Sep 29, 1:19 PM

Harbormaster completed remote builds in B77453: Diff 188000.Tue, Sep 29, 1:19 PM

christos requested review of this revision.Tue, Sep 29, 1:19 PM

christos retitled this revision from sound: Do not take PCM_LOCK just to mark the device busy to sound: Do not take PCM_LOCK just to busy the device.Tue, Sep 29, 1:20 PM

christos added a child revision: D60128: sound: Convert the SD_F_BUSY cv to an sx.Tue, Sep 29, 1:20 PM