Details
- Reviewers
ivy dteske - Commits
- rGeaeb5f29bc6f: sysrc: make independant from bsdconfig(8)
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 76873 Build 73756: arc lint + arc unit
Event Timeline
Title is incorrect. bsdconfig is not in section 1, but section 8.
Please switch bsdconfig . of sysrc.subr to f_include to support debug=1 and debugFile
| usr.sbin/bsdconfig/share/sysrc.subr | ||
|---|---|---|
| 36 | After you have sourced common.subr with . you should switch to using f_include for additional includes because it is not only more succinct, it (1) has debugging and (2) standardizes the exposure of the . exit status instead of forcing 1. | |
| usr.sbin/sysrc/sysrc.subr | ||
|---|---|---|
| 52–53 | Outside of bsdconfig this include has no i18n capabilities so the word “defaults” is not right. Suggest just making it short and sweet “Error messages” and non-English would require a new i18n faculty (e.g., bespoke case statement on LANG/LC_ALL if we ever wanted later). | |
This commit is causing a regression in the usr.sbin/sysrc/sysrc_test:A_flag testcase, but it looks like that testcase might now be stale right? @bapt could you take a look?
Fixed in 09711ccb09f482fd345b2b640dbbeb66de535041
NB: I admit that I should have prefixed the the commit title with "sysrc:" but at least we have the Fixes tag to show what the context is