Page MenuHomeFreeBSD
Differential D59457

buf_ring: support different lock classes
AcceptedPublic
Actions

Authored by glebius on Sat, Sep 5, 5:50 PM.
Tags
None
Referenced Files
F170911128: D59457.diff
Mon, Sep 7, 12:47 PM
F170839762: D59457.diff
Sun, Sep 6, 11:23 PM
F170839732: D59457.diff
Sun, Sep 6, 11:23 PM
F170810429: D59457.id185946.diff
Sun, Sep 6, 6:57 PM
F170804347: D59457.diff
Sun, Sep 6, 6:02 PM
F170792222: D59457.id185946.diff
Sun, Sep 6, 4:01 PM
F170791821: D59457.diff
Sun, Sep 6, 3:58 PM
Subscribers
ae
imp
melifaro
ngie
olce
ziaee

Details

Reviewers
kib
markj
gallatin
kp
Group Reviewers
Src Committers
Summary

And enable locking assertions for INVARIANTS kernel.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 76580
Build 73463: arc lint + arc unit

Event Timeline

glebius created this revision.Sat, Sep 5, 5:50 PM
Herald added subscribers: ziaee, olce, melifaro and 2 others. · View Herald TranscriptSat, Sep 5, 5:50 PM
Harbormaster completed remote builds in B76580: Diff 185946.Sat, Sep 5, 5:50 PM
glebius requested review of this revision.Sat, Sep 5, 5:50 PM
glebius added a parent revision: D59456: callout: provide callout_init_lock().
glebius added reviewers: gallatin, kp.Sat, Sep 5, 5:50 PM

@kp added you since it touches OpenVPN
@gallatin @kp note dependency on D59455

glebius updated this revision to Diff 186031.Sun, Sep 6, 7:56 PM
  • Use _Generic() instead of transparent union.
Harbormaster completed remote builds in B76605: Diff 186031.Sun, Sep 6, 7:56 PM
kib accepted this revision.Sun, Sep 6, 10:43 PM
This revision is now accepted and ready to land.Sun, Sep 6, 10:43 PM
ngie added a subscriber: ngie.Sun, Sep 6, 10:45 PM

This looks like it contains other changes from the diff stack. Did you mean to do that?

ngie added a comment.Sun, Sep 6, 10:47 PM
In D59457#1364325, @ngie wrote:

This looks like it contains other changes from the diff stack. Did you mean to do that?

Nevermind -- I see that you combined the changes. Sorry for the noise.

markj added inline comments.Sun, Sep 6, 11:45 PM
sys/sys/buf_ring.h
364

There is rwlock_padalign too.

369

Wouldn't it be better to add a standalone macro, lock2lock_object() or whatever, to sys/lock.h which maps a lock pointer to its lock object? This is pretty similar to the macro in D59456.

I see that some lock types are excluded from this list, but it's not clear why. buf_ring just asserts that the lock is held. It's fine to use a sleepable lock AFAICS. (And rmlocks can be sleepable anyway.)

markj mentioned this in D59456: callout: provide callout_init_lock().Mon, Sep 7, 1:10 PM

Revision Contents
Changeset List

PathSize
share/
man/
man9/
8 lines
sys/
kern/
6 lines
net/
2 lines
sys/
33 lines

Diff 185946

View Options

share/man/man9/buf_ring.9

Loading...
View Options

sys/kern/subr_bufring.c

Loading...
View Options

sys/net/if_ovpn.c

Loading...
View Options

sys/sys/buf_ring.h

Loading...