sys: Add sys/ckdint.h
ClosedPublic
Actions

Authored by markj on Mon, Aug 10, 10:05 PM.

Details

Reviewers

kib
emaste

Commits

rG37bd69d43c70: sys: Add sys/ckdint.h

Summary

We have a C23 stdckdint.h header for userspace, which provides checked
addition, subtraction and multiplication. We lack similar helpers in
the kernel, where they are regularly needed.

Let's just adopt the C23 macros. For bonus points, I added a wrapper to
ensure that ignored an return value is raised as an error by the
compiler. I also converted a couple of places in the kernel to use the
new macros. The netmap change in particular fixes a bug in my commit
319414a926af1515e2572f89f0636e5505e762d5.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 75533
Build 72416: arc lint + arc unit

Event Timeline

markj created this revision.Mon, Aug 10, 10:05 PM

Herald added subscribers: olce, imp. · View Herald TranscriptMon, Aug 10, 10:05 PM

markj requested review of this revision.Mon, Aug 10, 10:05 PM

Harbormaster completed remote builds in B75509: Diff 183839.Mon, Aug 10, 10:05 PM

markj edited the summary of this revision. (Show Details)Mon, Aug 10, 10:29 PM

kib accepted this revision.Tue, Aug 11, 11:00 AM

This revision is now accepted and ready to land.Tue, Aug 11, 11:00 AM

emaste accepted this revision.Tue, Aug 11, 7:25 PM

emaste added a subscriber: emaste.

emaste added inline comments.

sys/dev/netmap/netmap_mem2.c
2017–2022	Or even if (ckd_mul(&len, ndesc, sizeof(struct netmap_slot)) \|\| ckd_add(&len, len, sizeof(struct netmap_ring))) { error = EINVAL; goto cleanup; } To me at least this reads close to `ndesc * sizeof(struct netmap_slot) + sizeof(struct netmap_ring)` checked for overflow.