Page MenuHomeFreeBSD
Differential D56554

arm64/vmm: Move vttbr_el2 & vtimer into struct hypctx
ClosedPublic
Actions

Authored by kajetan.puchalski_arm.com on Apr 21 2026, 11:09 AM.
Tags
None
Referenced Files
F168548167: D56554.id176726.diff
Fri, Aug 28, 11:25 PM
F168466577: D56554.diff
Fri, Aug 28, 1:19 PM
F168447022: D56554.id179461.diff
Fri, Aug 28, 10:15 AM
F168443056: D56554.id180376.diff
Fri, Aug 28, 9:34 AM
F168441927: D56554.diff
Fri, Aug 28, 9:26 AM
F168440503: D56554.diff
Fri, Aug 28, 9:10 AM
F168407327: D56554.id179456.diff
Fri, Aug 28, 2:39 AM
Unknown Object (File)
Thu, Aug 27, 8:12 AM
View All Files
Subscribers
emaste
imp

Details

Reviewers
andrew
manu
Group Reviewers
arm64
Commits
rGf4c3458ab3ce: arm64/vmm: Move vttbr_el2 & vtimer into struct hypctx
Summary

Move vttbr_el2 & vtimer from struct hyp into struct hypctx to streamline
the logic and handle them in the same way as other *_el2 registers are
already being handled.

Signed-off-by: Kajetan Puchalski <kajetan.puchalski@arm.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 74412
Build 71295: arc lint + arc unit

Event Timeline

kajetan.puchalski_arm.com created this revision.Apr 21 2026, 11:09 AM
Herald added a reviewer: andrew. · View Herald TranscriptApr 21 2026, 11:09 AM
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added subscribers: emaste, imp. · View Herald Transcript
kajetan.puchalski_arm.com requested review of this revision.Apr 21 2026, 11:09 AM
Harbormaster completed remote builds in B72413: Diff 175977.Apr 21 2026, 11:09 AM
kajetan.puchalski_arm.com added a parent revision: D56553: arm64/vmm: Refactor vmm_hyp.c.Apr 21 2026, 11:09 AM
kajetan.puchalski_arm.com added a child revision: D56555: arm64/vmm: Move host-side EL2 regs into sys_regs.
kajetan.puchalski_arm.com updated this revision to Diff 176099.Apr 22 2026, 12:59 PM

Update with changes to other commits in the stack

Harbormaster completed remote builds in B72438: Diff 176099.Apr 22 2026, 12:59 PM
kajetan.puchalski_arm.com updated this revision to Diff 176105.Apr 22 2026, 1:23 PM

Encode VNCR values into enum hypctx_sysreg as 64-bit offsets

Harbormaster completed remote builds in B72444: Diff 176105.Apr 22 2026, 1:23 PM
kajetan.puchalski_arm.com updated this revision to Diff 176254.Apr 23 2026, 2:28 PM

Handle non-VHE, store the vncr page as a pointer

Harbormaster completed remote builds in B72472: Diff 176254.Apr 23 2026, 2:28 PM
kajetan.puchalski_arm.com updated this revision to Diff 176260.Apr 23 2026, 2:39 PM

Fix non-VHE omission

Harbormaster completed remote builds in B72478: Diff 176260.Apr 23 2026, 2:39 PM
kajetan.puchalski_arm.com updated this revision to Diff 176276.Apr 23 2026, 5:31 PM

Fix omission

Harbormaster completed remote builds in B72490: Diff 176276.Apr 23 2026, 5:31 PM
kajetan.puchalski_arm.com updated this revision to Diff 176318.Apr 24 2026, 11:09 AM

Use char* for ptr arithmetic

Harbormaster completed remote builds in B72510: Diff 176318.Apr 24 2026, 11:09 AM
kajetan.puchalski_arm.com updated this revision to Diff 176726.Apr 28 2026, 2:14 PM

Address remaining style review comments

Harbormaster completed remote builds in B72611: Diff 176726.Apr 28 2026, 2:14 PM
kajetan.puchalski_arm.com updated this revision to Diff 176986.May 1 2026, 11:09 AM

Use Static_assert to ensure correct struct hypctx size

Harbormaster completed remote builds in B72698: Diff 176986.May 1 2026, 11:09 AM
kajetan.puchalski_arm.com updated this revision to Diff 177459.May 8 2026, 2:44 PM

Correct nVHE omission

Harbormaster completed remote builds in B72930: Diff 177459.May 8 2026, 2:44 PM
kajetan.puchalski_arm.com updated this revision to Diff 178191.May 20 2026, 11:42 AM

Address review comments

Harbormaster completed remote builds in B73278: Diff 178191.May 20 2026, 11:42 AM
andrew accepted this revision.Jun 4 2026, 2:46 PM
This revision is now accepted and ready to land.Jun 4 2026, 2:46 PM
kajetan.puchalski_arm.com updated this revision to Diff 179456.Jun 9 2026, 3:28 PM

Fix indentation

This revision now requires review to proceed.Jun 9 2026, 3:28 PM
Harbormaster completed remote builds in B73760: Diff 179456.Jun 9 2026, 3:28 PM
kajetan.puchalski_arm.com updated this revision to Diff 179461.Jun 9 2026, 3:33 PM

Fix indentation

Harbormaster completed remote builds in B73765: Diff 179461.Jun 9 2026, 3:33 PM
kajetan.puchalski_arm.com updated this revision to Diff 180376.Jun 23 2026, 2:43 PM

Put potentially exotic registers in a separate array

Harbormaster completed remote builds in B74147: Diff 180376.Jun 23 2026, 2:43 PM
kajetan.puchalski_arm.com updated this revision to Diff 180983.Jun 30 2026, 2:17 PM

Only separate out registers relevant for morello

Harbormaster completed remote builds in B74412: Diff 180983.Jun 30 2026, 2:17 PM
andrew accepted this revision.Jun 30 2026, 3:02 PM
This revision is now accepted and ready to land.Jun 30 2026, 3:02 PM
Closed by commit rGf4c3458ab3ce: arm64/vmm: Move vttbr_el2 & vtimer into struct hypctx (authored by kajetan.puchalski_arm.com, committed by andrew). · Explain WhyJul 6 2026, 3:25 PM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rGf4c3458ab3ce: arm64/vmm: Move vttbr_el2 & vtimer into struct hypctx.

Revision Contents
Changeset List

PathSize
sys/
arm64/
vmm/
6 lines
io/
1 line
99 lines
4 lines
21 lines

Diff 180983

View Options

sys/arm64/vmm/arm64.h

Loading...
View Options

sys/arm64/vmm/io/vtimer.h

Loading...
View Options

sys/arm64/vmm/io/vtimer.c

Loading...
View Options

sys/arm64/vmm/vmm_arm64.c

Loading...
View Options

sys/arm64/vmm/vmm_hyp.c

Loading...