Details

Reviewers

andrew
manu

Group Reviewers

arm64

Summary

Move vttbr_el2 & vtimer from struct hyp into struct hypctx to streamline
the logic and handle them in the same way as other *_el2 registers are
already being handled.

Signed-off-by: Kajetan Puchalski <kajetan.puchalski@arm.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 74147
Build 71030: arc lint + arc unit

Event Timeline

kajetan.puchalski_arm.com created this revision.Apr 21 2026, 11:09 AM

Herald added a reviewer: andrew. · View Herald TranscriptApr 21 2026, 11:09 AM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added subscribers: emaste, imp. · View Herald Transcript

kajetan.puchalski_arm.com requested review of this revision.Apr 21 2026, 11:09 AM

Harbormaster completed remote builds in B72413: Diff 175977.Apr 21 2026, 11:09 AM

kajetan.puchalski_arm.com added a parent revision: D56553: arm64/vmm: Refactor vmm_hyp.c.Apr 21 2026, 11:09 AM

kajetan.puchalski_arm.com added a child revision: D56555: arm64/vmm: Move host-side EL2 regs into sys_regs.

Update with changes to other commits in the stack

Harbormaster completed remote builds in B72438: Diff 176099.Apr 22 2026, 12:59 PM

Encode VNCR values into enum hypctx_sysreg as 64-bit offsets

Harbormaster completed remote builds in B72444: Diff 176105.Apr 22 2026, 1:23 PM

Handle non-VHE, store the vncr page as a pointer

Harbormaster completed remote builds in B72472: Diff 176254.Apr 23 2026, 2:28 PM

Fix non-VHE omission

Harbormaster completed remote builds in B72478: Diff 176260.Apr 23 2026, 2:39 PM

Fix omission

Harbormaster completed remote builds in B72490: Diff 176276.Apr 23 2026, 5:31 PM

Use char* for ptr arithmetic

Harbormaster completed remote builds in B72510: Diff 176318.Apr 24 2026, 11:09 AM

Address remaining style review comments

Harbormaster completed remote builds in B72611: Diff 176726.Apr 28 2026, 2:14 PM

Use Static_assert to ensure correct struct hypctx size

Harbormaster completed remote builds in B72698: Diff 176986.May 1 2026, 11:09 AM

Correct nVHE omission

Harbormaster completed remote builds in B72930: Diff 177459.May 8 2026, 2:44 PM

Address review comments

Harbormaster completed remote builds in B73278: Diff 178191.May 20 2026, 11:42 AM

andrew accepted this revision.Thu, Jun 4, 2:46 PM

This revision is now accepted and ready to land.Thu, Jun 4, 2:46 PM

Fix indentation

This revision now requires review to proceed.Tue, Jun 9, 3:28 PM

Harbormaster completed remote builds in B73760: Diff 179456.Tue, Jun 9, 3:28 PM

Fix indentation

Harbormaster completed remote builds in B73765: Diff 179461.Tue, Jun 9, 3:33 PM

Put potentially exotic registers in a separate array

Harbormaster completed remote builds in B74147: Diff 180376.Tue, Jun 23, 2:43 PM

arm64/vmm: Move vttbr_el2 & vtimer into struct hypctx
Needs ReviewPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 180376

sys/arm64/vmm/arm64.h

sys/arm64/vmm/io/vtimer.h

sys/arm64/vmm/io/vtimer.c

sys/arm64/vmm/vmm_arm64.c

sys/arm64/vmm/vmm_hyp.c

arm64/vmm: Move vttbr_el2 & vtimer into struct hypctxNeeds ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 180376

sys/arm64/vmm/arm64.h

sys/arm64/vmm/io/vtimer.h

sys/arm64/vmm/io/vtimer.c

sys/arm64/vmm/vmm_arm64.c

sys/arm64/vmm/vmm_hyp.c

arm64/vmm: Move vttbr_el2 & vtimer into struct hypctx
Needs ReviewPublic
Actions

Revision Contents
Changeset List