This "fixes" the issue, but the tests should also be intelligent enough to understand when the OPENSSL_KTLS feature isn't present and skip the tests if the feature isn't present in the kernel (see ATF_REQUIRE_FEATURE, etc).

In D57316#1313745, @ngie wrote:

This "fixes" the issue, but the tests should also be intelligent enough to understand when the OPENSSL_KTLS feature isn't present and skip the tests if the feature isn't present in the kernel (see ATF_REQUIRE_FEATURE, etc).

ATF_REQUIRE_FEATURE is awfully unidiomatic, we should implement a require.features property instead.

In D57316#1314576, @des wrote:

In D57316#1313745, @ngie wrote:

This "fixes" the issue, but the tests should also be intelligent enough to understand when the OPENSSL_KTLS feature isn't present and skip the tests if the feature isn't present in the kernel (see ATF_REQUIRE_FEATURE, etc).

ATF_REQUIRE_FEATURE is awfully unidiomatic, we should implement a require.features property instead.

I agree.. just not sure how to handle it yet with other platforms where this feature might not be available. Probably should just push forward with the OS-specific handler behavior in kyua for FreeBSD started by @igoro .

In D57316#1315185, @ngie wrote:

In D57316#1314576, @des wrote:

In D57316#1313745, @ngie wrote:

This "fixes" the issue, but the tests should also be intelligent enough to understand when the OPENSSL_KTLS feature isn't present and skip the tests if the feature isn't present in the kernel (see ATF_REQUIRE_FEATURE, etc).

ATF_REQUIRE_FEATURE is awfully unidiomatic, we should implement a require.features property instead.

I agree.. just not sure how to handle it yet with other platforms where this feature might not be available. Probably should just push forward with the OS-specific handler behavior in kyua for FreeBSD started by @igoro .

Yes, it could be implemented that way. The patch is designed in a way that allows new handlers to be introduced later: https://reviews.freebsd.org/D48087. By the way, it has been ready for landing for quite some time. @ngie , it just waits for your formal approval. All the comments have been addressed there.