Page MenuHomeFreeBSD
Differential D56555

arm64/vmm: Move host-side EL2 regs into sys_regs
AcceptedPublic
Actions

Authored by kajetan.puchalski_arm.com on Apr 21 2026, 11:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jul 5, 7:42 AM
Unknown Object (File)
Sat, Jul 4, 6:13 PM
Unknown Object (File)
Fri, Jul 3, 2:49 AM
Unknown Object (File)
Wed, Jul 1, 2:41 AM
Unknown Object (File)
Fri, Jun 26, 7:18 PM
Unknown Object (File)
Fri, Jun 26, 3:14 PM
Unknown Object (File)
Thu, Jun 25, 6:32 PM
Unknown Object (File)
Thu, Jun 25, 10:01 AM
View All 83 Files
Subscribers
emaste
imp

Details

Reviewers
andrew
manu
Group Reviewers
arm64
Summary

Move EL2 host registers that are not visible to the guest into
hypctx->sys_regs. Prefix them with HOST_ to distinguish from EL2
registers which are part of the guest's own state (e.g. in VNCR).

Signed-off-by: Kajetan Puchalski <kajetan.puchalski@arm.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 73761
Build 70644: arc lint + arc unit

Event Timeline

kajetan.puchalski_arm.com created this revision.Apr 21 2026, 11:09 AM
Herald added a reviewer: andrew. · View Herald TranscriptApr 21 2026, 11:09 AM
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added subscribers: emaste, imp. · View Herald Transcript
kajetan.puchalski_arm.com requested review of this revision.Apr 21 2026, 11:09 AM
Harbormaster completed remote builds in B72414: Diff 175978.Apr 21 2026, 11:09 AM
kajetan.puchalski_arm.com added a parent revision: D56554: arm64/vmm: Move vttbr_el2 & vtimer into struct hypctx.Apr 21 2026, 11:09 AM
kajetan.puchalski_arm.com added a child revision: D56556: arm64/vmm: Make remaining registers use hypctx_*_sys_reg.
kajetan.puchalski_arm.com updated this revision to Diff 176100.Apr 22 2026, 12:59 PM

Update

Harbormaster completed remote builds in B72439: Diff 176100.Apr 22 2026, 12:59 PM
kajetan.puchalski_arm.com updated this revision to Diff 176106.Apr 22 2026, 1:24 PM

Encode VNCR values into enum hypctx_sysreg as 64-bit offsets

Harbormaster completed remote builds in B72445: Diff 176106.Apr 22 2026, 1:24 PM
kajetan.puchalski_arm.com updated this revision to Diff 176255.Apr 23 2026, 2:28 PM

Handle non-VHE, store the vncr page as a pointer

Harbormaster completed remote builds in B72473: Diff 176255.Apr 23 2026, 2:28 PM
kajetan.puchalski_arm.com updated this revision to Diff 176261.Apr 23 2026, 2:39 PM

Fix non-VHE omission

Harbormaster completed remote builds in B72479: Diff 176261.Apr 23 2026, 2:39 PM
kajetan.puchalski_arm.com updated this revision to Diff 176277.Apr 23 2026, 5:31 PM

Fix omission

Harbormaster completed remote builds in B72491: Diff 176277.Apr 23 2026, 5:31 PM
kajetan.puchalski_arm.com updated this revision to Diff 176319.Apr 24 2026, 11:09 AM

Use char* for ptr arithmetic

Harbormaster completed remote builds in B72511: Diff 176319.Apr 24 2026, 11:09 AM
kajetan.puchalski_arm.com updated this revision to Diff 176727.Apr 28 2026, 2:14 PM

Address remaining style review comments

Harbormaster completed remote builds in B72612: Diff 176727.Apr 28 2026, 2:14 PM
kajetan.puchalski_arm.com updated this revision to Diff 176987.May 1 2026, 11:10 AM

Use Static_assert to ensure correct struct hypctx size

Harbormaster completed remote builds in B72699: Diff 176987.May 1 2026, 11:10 AM
kajetan.puchalski_arm.com updated this revision to Diff 177460.May 8 2026, 2:44 PM

Correct nVHE omission

Harbormaster completed remote builds in B72931: Diff 177460.May 8 2026, 2:44 PM
kajetan.puchalski_arm.com updated this revision to Diff 178192.May 20 2026, 11:42 AM

Address review comments

Harbormaster completed remote builds in B73279: Diff 178192.May 20 2026, 11:42 AM
andrew added a comment.Jun 4 2026, 2:48 PM

I looks like some lines might be wider than 80 characters

sys/arm64/vmm/vmm_hyp.c
170–172

Style

kajetan.puchalski_arm.com updated this revision to Diff 179457.Tue, Jun 9, 3:28 PM

Fix indentation

Harbormaster completed remote builds in B73761: Diff 179457.Tue, Jun 9, 3:28 PM
kajetan.puchalski_arm.com updated this revision to Diff 179462.Tue, Jun 9, 3:33 PM

Fix indentation

Harbormaster completed remote builds in B73766: Diff 179462.Tue, Jun 9, 3:33 PM
kajetan.puchalski_arm.com updated this revision to Diff 179465.Tue, Jun 9, 4:35 PM

Fix indentation

Harbormaster completed remote builds in B73769: Diff 179465.Tue, Jun 9, 4:35 PM
kajetan.puchalski_arm.com marked an inline comment as done.Tue, Jun 9, 4:36 PM
kajetan.puchalski_arm.com updated this revision to Diff 180377.Tue, Jun 23, 2:43 PM

Put potentially exotic registers in a separate array

Harbormaster completed remote builds in B74148: Diff 180377.Tue, Jun 23, 2:43 PM
kajetan.puchalski_arm.com updated this revision to Diff 180984.Tue, Jun 30, 2:17 PM

Only separate out registers relevant for morello

Harbormaster completed remote builds in B74413: Diff 180984.Tue, Jun 30, 2:17 PM
andrew accepted this revision.Wed, Jul 1, 10:51 AM
This revision is now accepted and ready to land.Wed, Jul 1, 10:51 AM

Revision Contents
Changeset List

PathSize
sys/
arm64/
vmm/
70 lines
io/
6 lines
26 lines
82 lines
362 lines

Diff 179457

View Options

sys/arm64/vmm/arm64.h

Loading...
View Options

sys/arm64/vmm/io/vgic_v3.c

Loading...
View Options

sys/arm64/vmm/vmm_arm64.c

Loading...
View Options

sys/arm64/vmm/vmm_hyp.c

Loading...
View Options

sys/arm64/vmm/vmm_reset.c

Loading...