Details

Reviewers

andrew
manu

Group Reviewers

arm64

Commits

rGee2642678a2c: arm64/vmm: Move host-side EL2 regs into sys_regs

Summary

Move EL2 host registers that are not visible to the guest into
hypctx->sys_regs. Prefix them with HOST_ to distinguish from EL2
registers which are part of the guest's own state (e.g. in VNCR).

Signed-off-by: Kajetan Puchalski <kajetan.puchalski@arm.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 72439
Build 69322: arc lint + arc unit

Event Timeline

kajetan.puchalski_arm.com created this revision.Apr 21 2026, 11:09 AM

Herald added a reviewer: andrew. · View Herald TranscriptApr 21 2026, 11:09 AM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added subscribers: emaste, imp. · View Herald Transcript

kajetan.puchalski_arm.com requested review of this revision.Apr 21 2026, 11:09 AM

Harbormaster completed remote builds in B72414: Diff 175978.Apr 21 2026, 11:09 AM

kajetan.puchalski_arm.com added a parent revision: D56554: arm64/vmm: Move vttbr_el2 & vtimer into struct hypctx.Apr 21 2026, 11:09 AM

kajetan.puchalski_arm.com added a child revision: D56556: arm64/vmm: Make remaining registers use hypctx_*_sys_reg.

Update

Harbormaster completed remote builds in B72439: Diff 176100.Apr 22 2026, 12:59 PM

Encode VNCR values into enum hypctx_sysreg as 64-bit offsets

Harbormaster completed remote builds in B72445: Diff 176106.Apr 22 2026, 1:24 PM

Handle non-VHE, store the vncr page as a pointer

Harbormaster completed remote builds in B72473: Diff 176255.Apr 23 2026, 2:28 PM

Fix non-VHE omission

Harbormaster completed remote builds in B72479: Diff 176261.Apr 23 2026, 2:39 PM

Fix omission

Harbormaster completed remote builds in B72491: Diff 176277.Apr 23 2026, 5:31 PM

Use char* for ptr arithmetic

Harbormaster completed remote builds in B72511: Diff 176319.Apr 24 2026, 11:09 AM

Address remaining style review comments

Harbormaster completed remote builds in B72612: Diff 176727.Apr 28 2026, 2:14 PM

Use Static_assert to ensure correct struct hypctx size

Harbormaster completed remote builds in B72699: Diff 176987.May 1 2026, 11:10 AM

Correct nVHE omission

Harbormaster completed remote builds in B72931: Diff 177460.May 8 2026, 2:44 PM

Address review comments

Harbormaster completed remote builds in B73279: Diff 178192.May 20 2026, 11:42 AM

I looks like some lines might be wider than 80 characters

sys/arm64/vmm/vmm_hyp.c
159–160	Style

Fix indentation

Harbormaster completed remote builds in B73761: Diff 179457.Jun 9 2026, 3:28 PM

Fix indentation

Harbormaster completed remote builds in B73766: Diff 179462.Jun 9 2026, 3:33 PM

Fix indentation

Harbormaster completed remote builds in B73769: Diff 179465.Jun 9 2026, 4:35 PM

kajetan.puchalski_arm.com marked an inline comment as done.Jun 9 2026, 4:36 PM

Put potentially exotic registers in a separate array

Harbormaster completed remote builds in B74148: Diff 180377.Jun 23 2026, 2:43 PM

Only separate out registers relevant for morello

Harbormaster completed remote builds in B74413: Diff 180984.Jun 30 2026, 2:17 PM

andrew accepted this revision.Jul 1 2026, 10:51 AM

This revision is now accepted and ready to land.Jul 1 2026, 10:51 AM

Closed by commit rGee2642678a2c: arm64/vmm: Move host-side EL2 regs into sys_regs (authored by kajetan.puchalski_arm.com, committed by andrew). · Explain WhyJul 6 2026, 3:25 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rGee2642678a2c: arm64/vmm: Move host-side EL2 regs into sys_regs.

arm64/vmm: Move host-side EL2 regs into sys_regs
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 176100

sys/arm64/vmm/arm64.h

sys/arm64/vmm/io/vgic_v3.c

sys/arm64/vmm/vmm_arm64.c

sys/arm64/vmm/vmm_hyp.c

sys/arm64/vmm/vmm_reset.c

arm64/vmm: Move host-side EL2 regs into sys_regsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 176100

sys/arm64/vmm/arm64.h

sys/arm64/vmm/io/vgic_v3.c

sys/arm64/vmm/vmm_arm64.c

sys/arm64/vmm/vmm_hyp.c

sys/arm64/vmm/vmm_reset.c

arm64/vmm: Move host-side EL2 regs into sys_regs
ClosedPublic
Actions

Revision Contents
Changeset List