Otherwise an unprivileged user can disable randomization of the base
address for PIEs even if they are setugid.
Add a regression test.
Reported by: David Berard
Details
Details
- Reviewers
brooks kib emaste - Commits
- rGe417948e6139: imgact_elf: Clear no-ASLR and -WXORX flags earlier for setugid images
rG796579bcfbc4: imgact_elf: Clear no-ASLR and -WXORX flags earlier for setugid images
rG6e51dfc401e7: imgact_elf: Clear no-ASLR and -WXORX flags earlier for setugid images
rG547fc2a98a24: imgact_elf: Clear no-ASLR and -WXORX flags earlier for setugid images
rG744f62ccbf82: imgact_elf: Clear no-ASLR and -WXORX flags earlier for setugid images
rGe1cdc49846c1: imgact_elf: Clear no-ASLR and -WXORX flags earlier for setugid images
rGebb0ea9f4f59: imgact_elf: Clear no-ASLR and -WXORX flags earlier for setugid images
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 73635 Build 70518: arc lint + arc unit
Event Timeline
| sys/kern/imgact_elf.c | ||
|---|---|---|
| 1366 | Why moving the VOP_UNLOCK line? If moving, I would put it before the newly moved check imgp->credential_setid | |
| sys/kern/imgact_elf.c | ||
|---|---|---|
| 1366 | I did it this way to avoid changing error handling, and to keep related blocks of code close together. In particular, goto ret requires the vnode to be locked. If you prefer, I will move it earlier and add a new goto label. | |
| sys/kern/imgact_elf.c | ||
|---|---|---|
| 1366 | I think it is simpler to relock the vnode before goto. Yes, I think it makes sense to move the unlock earlier. | |