Page MenuHomeFreeBSD
Differential D56675

Fix LOCAL_PEERCRED in 32-bit compat mode
ClosedPublic
Actions

Authored by asomers on Apr 27 2026, 11:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Aug 4, 6:41 AM
Unknown Object (File)
Tue, Aug 4, 3:05 AM
Unknown Object (File)
Tue, Aug 4, 2:55 AM
Unknown Object (File)
Mon, Aug 3, 6:07 AM
Unknown Object (File)
Fri, Jul 31, 1:54 AM
Unknown Object (File)
Thu, Jul 30, 8:15 PM
Unknown Object (File)
Wed, Jul 29, 2:58 PM
Unknown Object (File)
Mon, Jul 20, 9:52 AM
View All 46 Files
Subscribers
emaste
glebius
imp
miguel.dias.gomes_protonmail.com
olce

Details

Reviewers
sobomax
emaste
Commits
rG66c61a685c73: Fix LOCAL_PEERCRED in 32-bit compat mode
rG39fcfcc64bba: Fix LOCAL_PEERCRED in 32-bit compat mode
rG3298d82ea340: Fix LOCAL_PEERCRED in 32-bit compat mode
rG1d24638d3e88: Fix LOCAL_PEERCRED in 32-bit compat mode
Summary

Previously the cr_pid field would be incorrectly copied to userland, due
to a size mismatch between the structure as defined in 32-bit vs 64-bit
builds. Fix it by converting the structure before copying it to
userland.

PR: 294833
Sponsored by: ConnectWise
MFC after: 1 week

Test Plan

Used the test program in Bugzilla

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

asomers created this revision.Apr 27 2026, 11:50 PM
Herald added subscribers: olce, glebius, imp. · View Herald TranscriptApr 27 2026, 11:50 PM
asomers requested review of this revision.Apr 27 2026, 11:50 PM
Harbormaster completed remote builds in B72591: Diff 176683.Apr 27 2026, 11:50 PM
emaste added a subscriber: emaste.Apr 28 2026, 5:44 PM
emaste added inline comments.
sys/kern/uipc_usrreq.c
2760
asomers updated this revision to Diff 176753.Apr 28 2026, 6:08 PM
  • Respond to emaste's style comment.
Harbormaster completed remote builds in B72626: Diff 176753.Apr 28 2026, 6:08 PM
emaste added a comment.Apr 28 2026, 6:09 PM

Not just style, we don't want to leak kernel stack in struct gaps

emaste accepted this revision.Apr 28 2026, 6:10 PM

LGTM, feel free to give other reviewers some time.

This revision is now accepted and ready to land.Apr 28 2026, 6:10 PM
asomers added a comment.Apr 28 2026, 6:13 PM
In D56675#1298767, @emaste wrote:

LGTM, feel free to give other reviewers some time.

Thanks Ed. I'll wait a little while before committing.

Closed by commit rG1d24638d3e88: Fix LOCAL_PEERCRED in 32-bit compat mode (authored by asomers). · Explain WhyMay 7 2026, 9:07 PM
This revision was automatically updated to reflect the committed changes.
asomers added a commit: rG1d24638d3e88: Fix LOCAL_PEERCRED in 32-bit compat mode.
asomers added a commit: rG3298d82ea340: Fix LOCAL_PEERCRED in 32-bit compat mode.May 13 2026, 5:23 PM
cperciva added a commit: rG39fcfcc64bba: Fix LOCAL_PEERCRED in 32-bit compat mode.May 14 2026, 7:06 PM
miguel.dias.gomes_protonmail.com added a subscriber: miguel.dias.gomes_protonmail.com.May 16 2026, 3:16 PM
asomers added a commit: rG66c61a685c73: Fix LOCAL_PEERCRED in 32-bit compat mode.Wed, Aug 5, 2:35 AM

Revision Contents
Changeset List

PathSize
sys/
kern/
21 lines
sys/
11 lines

Diff 177425

View Options

sys/kern/uipc_usrreq.c

Loading...
View Options

sys/sys/ucred.h

Loading...