MFC after: 3 days
Reported by: ivy
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 72003 Build 68886: arc lint + arc unit
Event Timeline
| share/man/man7/build.7 | ||
|---|---|---|
| 585 | the actual paths are /boot/${INSTKERNNAME} and /boot/${INSTKERNNAME}.NAME, where INSTKERNNAME defaults to "kernel". this is useful information (especially for pkgbase users), so it might be worth mentioning. | |
| 589 | this existing text is not technically correct: for powerpc64, the default kernel is GENERIC64, and for powerpc64le, it's GENERIC64LE. those are both tier 2 platforms, so i don't know if that's worth mentioning. | |
Comment Actions
this looks okay, other than a couple of nits that i won't insist on. i do wonder if we want to be more explicit about how this affects pkgbase, but i don't think this is the right place for that.
| share/man/man7/build.7 | ||
|---|---|---|
| 582 | it might be worth mentioning more explicitly how this affects where the kernel will be installed, e.g. if you run: % make INSTKERNNAME=testkernel buildkernel installkernel then the kernel will be installed to /boot/testkernel. the existing text, "an alternative name to build and install", doesn't seem very meaningful to me. (as far as i know, this doesn't affect the build at all, only how it's installed.) | |
| 597 | this also affects PowerPC targets, not just POWER -- powerpc runs on both, and we do still support some old Mac PowerPC systems. (i think the embedded Freescale/NXP stuff is now branded as "Power Architecture" rather than PowerPC.) specifically, this applies when TARGET=powerpc and either TARGET_ARCH=powerpc64 or TARGET_ARCH=powerpc64le. if we can't come up with reasonable language to express that concisely, i'm okay with leaving it as "POWER architectures". | |