Page MenuHomeFreeBSD
Differential D56130

nd6: break nd6_prefix_update out of prelist_update
AcceptedPublic
Actions

Authored by pouria on Sat, Mar 28, 8:13 PM.
Tags
None
Referenced Files
F150566159: D56130.diff
Thu, Apr 2, 10:26 AM
Unknown Object (File)
Tue, Mar 31, 6:03 AM
Unknown Object (File)
Mon, Mar 30, 1:13 PM
Subscribers
ae
imp
melifaro

Details

Reviewers
markj
glebius
bz
Group Reviewers
network
Summary

if PI exists, call prefix_update, instead of doing it inside the prelist_update.
no functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 71778
Build 68661: arc lint + arc unit

Event Timeline

pouria created this revision.Sat, Mar 28, 8:13 PM
Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptSat, Mar 28, 8:13 PM
pouria requested review of this revision.Sat, Mar 28, 8:13 PM
Harbormaster completed remote builds in B71778: Diff 174454.Sat, Mar 28, 8:13 PM
pouria added a child revision: D56131: nd6: break pfxrtr_add out of nd6_prelist_add.Sat, Mar 28, 8:13 PM
pouria added a comment.Sat, Mar 28, 8:27 PM

For reviewers:
The whole revision stack will reduce PI code complexity and fix multiple issues along the way.
I also wrote additional tests in D56128 to make sure everything works as intended.

markj added inline comments.Sun, Mar 29, 7:14 AM
sys/netinet6/nd6_rtr.c
1533

Before, prelist_update() would return the value of error in this case. Now it does not. Is it intentional?

markj accepted this revision.Sun, Mar 29, 7:16 AM
markj added inline comments.
sys/netinet6/nd6_rtr.c
1533

After D54132 it does not matter, okay.

This revision is now accepted and ready to land.Sun, Mar 29, 7:16 AM
pouria marked 2 inline comments as done.Sun, Mar 29, 10:52 AM
pouria added inline comments.
sys/netinet6/nd6_rtr.c
1533

*D56132. Thanks!

ae added a comment.Sun, Mar 29, 3:28 PM
In D56130#1283954, @pouria wrote:

For reviewers:
The whole revision stack will reduce PI code complexity and fix multiple issues along the way.
I also wrote additional tests in D56128 to make sure everything works as intended.

Can you show what issues you are talking about?
I also have the patch related to prefixes and CARP.

pouria marked an inline comment as done.Tue, Mar 31, 8:45 PM
In D56130#1284183, @ae wrote:

Can you show what issues you are talking about?
I also have the patch related to prefixes and CARP.

I've mostly done cleanups and preparation for my other patches:

  • removing several unused conditions
  • broke down of a large function with ~350 lines.
  • fixes some DRY issues.

I took a quick look at your patch, I'll have multiple conflicts with it, especially because you used some reserved RA flags.

pouria retitled this revision from ndp: break nd6_prefix_update out of prelist_update to nd6: break nd6_prefix_update out of prelist_update.Wed, Apr 1, 4:06 PM

Revision Contents
Changeset List

PathSize
sys/
netinet6/
78 lines

Diff 174454

View Options

sys/netinet6/nd6_rtr.c

Loading...