nd6: Do not enter net_epoch under nd6_prelist_add
AcceptedPublic
Actions

Authored by pouria on Sat, Mar 28, 8:01 PM.

Details

Reviewers

markj
glebius
bz
zlei

Group Reviewers

network

Summary

nd6_prefix_onlink will enter net_epoch when necessary.
Also, exit net_epoch earlier in nd6_prefix_onlink,
Because we acquired a reference to ifa, and we got our ifa
from the pr->ndpr_ifp, we don't need to stay under epoch.
While here, style it.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 71777
Build 68660: arc lint + arc unit

Event Timeline

pouria created this revision.Sat, Mar 28, 8:01 PM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptSat, Mar 28, 8:01 PM

Harbormaster completed remote builds in B71777: Diff 174453.Sat, Mar 28, 8:01 PM

pouria requested review of this revision.Sat, Mar 28, 8:01 PM

Seems ok.

This revision is now accepted and ready to land.Sun, Mar 29, 7:07 AM

The commit title needs to be fixed though, "Don NOT" -> "Do not"

pouria retitled this revision from ndp: Don NOT enter net_epoch under nd6_prelist_add to ndp: Do not enter net_epoch under nd6_prelist_add.Sun, Mar 29, 11:00 AM

zlei added a subscriber: zlei.Sun, Mar 29, 6:22 PM

zlei added inline comments.

sys/netinet6/nd6_rtr.c
1420	This change looks good to me.
2168	I'd recommend against this. A recursive `NET_EPOCH_ENTER()` has less performance impact vs a re-enter epoch. CC @glebius for this change.

pouria retitled this revision from ndp: Do not enter net_epoch under nd6_prelist_add to nd6: Do not enter net_epoch under nd6_prelist_add.Wed, Apr 1, 4:52 PM

pouria added a reviewer: zlei.Wed, Apr 1, 4:54 PM

pouria added inline comments.

sys/netinet6/nd6_rtr.c
2168	Will wait for @glebius response

Revision Contents
Changeset List

Path

Size

sys/

netinet6/

nd6_rtr.c

9 lines

Diff 174453

View Options

nd6: Do not enter net_epoch under nd6_prelist_addAcceptedPublicActions