netinet6: embed struct scope6_id into struct in6_ifextra
Needs ReviewPublic
Actions

Authored by glebius on Thu, Jan 15, 3:25 AM.

Details

Reviewers

Group Reviewers

network
transport

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 69901
Build 66784: arc lint + arc unit

Event Timeline

glebius created this revision.Thu, Jan 15, 3:25 AM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptThu, Jan 15, 3:25 AM

glebius requested review of this revision.Thu, Jan 15, 3:25 AM

Harbormaster completed remote builds in B69901: Diff 169754.Thu, Jan 15, 3:25 AM

glebius added a parent revision: D54725: netinet6: store ND context directly in struct in6_ifextra.Thu, Jan 15, 3:25 AM

glebius added a child revision: D54727: netinet6: embed struct mld_ifsoftc into struct in6_ifextra.

Do we still need this? I think scope modification ability was not used/implemented since KAME import.

I have very little idea about that. I'm just working on making interfaces detach more safe and I want in6_ifextra to be a single piece of memory which would have delayed reclamation.

I'd be very happy if an IPv6 expert comes and axes of pieces of IPv6 that aren't needed at all. Some locking in scope6.c looks suspicious to me, so I doubt the code is actively used indeed.