Paths

Table of Contentst

Differential D52825

ip6+carp: revise the generation of ND6 NA
ClosedPublic
Actions

Authored by ae on Oct 1 2025, 12:17 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Mar 25, 5:08 AM

	Unknown Object (File)
	Tue, Mar 24, 8:38 PM

	Unknown Object (File)
	Mon, Mar 23, 4:32 AM

	Unknown Object (File)
	Thu, Mar 19, 11:30 AM

	Unknown Object (File)
	Thu, Mar 19, 4:58 AM

	Unknown Object (File)
	Thu, Mar 19, 4:58 AM

	Unknown Object (File)
	Sun, Mar 15, 9:57 AM

	Unknown Object (File)
	Wed, Mar 11, 9:59 AM

View All 46 Files

Subscribers

Details

Reviewers

melifaro
kp
zlei

Group Reviewers

Commits

rG7a2a874a0b46: carp6: revise the generation of ND6 NA
rG2efda1b8c0f9: carp6: revise the generation of ND6 NA
rG716acd9367df: carp6: revise the generation of ND6 NA

Summary

use ND_NA_FLAG_ROUTER flag in carp_send_na() when we work as router
use in6addr_any as destination address for nd6_na_output(), then it will use ipv6-all-nodes multicast address.
add in6_selectsrc_nbr() function that accepts additional argument ip6_moptions. Use this function from ND6 code to avoid cases when nd6_na_output/nd6_ns_output can not find source address for multicast destinations:

kernel: carp: 83@vlan524: BACKUP -> MASTER (master will time out)
kernel: nd6_na_output: source can't be determined: dst=ff02::1, error=51

add some comments from RFC2461 for better understanding.
use tlladdr argument as flags and use ND6_NA_OPT_LLA when we need to add target link-layer address option, and ND6_NA_CARP_MASTER when we know that target address is CARP master. Then we can call carp_macmatch6() if target address is CARP master and ND6 NA packet will have correct mac address.
move blocks of code where multicast options is initialized and use it when destination address is multicast. Thus we can set M_MCAST flag and prepare ip6_moptions for correct IPv6 source address selection.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 67449
Build 64332: arc lint + arc unit

Event Timeline

ae created this revision.Oct 1 2025, 12:17 PM

ae held this revision as a draft.

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptOct 1 2025, 12:17 PM

Harbormaster completed remote builds in B67449: Diff 163220.Oct 1 2025, 12:17 PM

ae added reviewers: network, melifaro, kp, zlei.Oct 1 2025, 12:19 PM

ae published this revision for review.Oct 1 2025, 12:26 PM

ae edited the summary of this revision. (Show Details)

kp accepted this revision as: kp.Oct 2 2025, 8:35 AM

This revision is now accepted and ready to land.Oct 2 2025, 8:35 AM

Closed by commit rG716acd9367df: carp6: revise the generation of ND6 NA (authored by ae). · Explain WhyOct 3 2025, 8:02 AM

This revision was automatically updated to reflect the committed changes.

ae added a commit: rG716acd9367df: carp6: revise the generation of ND6 NA.

ae added a commit: rG2efda1b8c0f9: carp6: revise the generation of ND6 NA.Oct 18 2025, 12:02 PM

ae added a commit: rG7a2a874a0b46: carp6: revise the generation of ND6 NA.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

27 lines

netinet6/

54 lines

2 lines

4 lines

121 lines

Diff 163220

sys/netinet/ip_carp.c

Loading...

sys/netinet6/in6_src.c

Loading...

sys/netinet6/ip6_var.h

Loading...

sys/netinet6/nd6.h

Loading...

sys/netinet6/nd6_nbr.c

Loading...