Page MenuHomeFreeBSD
Differential D51029

ufshci: add man page
ClosedPublic
Actions

Authored by j_yoon.choi_samsung.com on Wed, Jun 25, 1:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jul 18, 11:12 AM
Unknown Object (File)
Wed, Jul 16, 11:48 PM
Unknown Object (File)
Sun, Jul 13, 10:00 AM
Unknown Object (File)
Fri, Jul 11, 3:10 PM
Unknown Object (File)
Fri, Jul 11, 1:05 PM
Unknown Object (File)
Sun, Jul 6, 5:31 AM
Unknown Object (File)
Sat, Jul 5, 7:26 AM
Unknown Object (File)
Wed, Jun 25, 10:37 PM
Subscribers
imp
lwhsu
pauamma_gundo.com
rpokala
ziaee

Details

Reviewers
imp
julian
pauamma_gundo.com
rpokala
Group Reviewers
manpages
Commits
rG93f7ed6ca9cc: ufshci: add man page
Summary

Sponsored by: Samsung Electronics

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

j_yoon.choi_samsung.com created this revision.Wed, Jun 25, 1:47 AM
Herald added subscribers: ziaee, imp. · View Herald TranscriptWed, Jun 25, 1:47 AM
j_yoon.choi_samsung.com requested review of this revision.Wed, Jun 25, 1:47 AM
Harbormaster completed remote builds in B65068: Diff 157561.Wed, Jun 25, 1:47 AM
j_yoon.choi_samsung.com added a reviewer: imp.Wed, Jun 25, 1:48 AM
j_yoon.choi_samsung.com updated this revision to Diff 157569.Wed, Jun 25, 3:14 AM

Add ufshci to Makefile

Harbormaster completed remote builds in B65070: Diff 157569.Wed, Jun 25, 3:14 AM
j_yoon.choi_samsung.com added a reviewer: manpages.Wed, Jun 25, 4:30 AM
j_yoon.choi_samsung.com updated this revision to Diff 157574.Wed, Jun 25, 4:47 AM

initialisation -> initialization

Harbormaster completed remote builds in B65075: Diff 157574.Wed, Jun 25, 4:48 AM
lwhsu added a subscriber: lwhsu.Wed, Jun 25, 5:18 PM
j_yoon.choi_samsung.com added a reviewer: julian.Wed, Jul 2, 12:33 AM
imp accepted this revision.Wed, Jul 9, 3:08 AM

This looks good as is.

This revision is now accepted and ready to land.Wed, Jul 9, 3:08 AM
pauamma_gundo.com added a subscriber: pauamma_gundo.com.Thu, Jul 10, 1:47 AM

Other than that precision, nothing jumps out to me.

share/man/man4/ufshci.4
86

Worth stating the unit (seconds, milliseconds, or whichever)?

j_yoon.choi_samsung.com updated this revision to Diff 158253.Thu, Jul 10, 4:24 AM

Apply review comment

This revision now requires review to proceed.Thu, Jul 10, 4:24 AM
Harbormaster completed remote builds in B65316: Diff 158253.Thu, Jul 10, 4:24 AM
j_yoon.choi_samsung.com marked an inline comment as done.Thu, Jul 10, 4:28 AM
j_yoon.choi_samsung.com added inline comments.
share/man/man4/ufshci.4
86

I added "(in seconds)". Thanks :)

pauamma_gundo.com accepted this revision.Thu, Jul 10, 8:01 PM
This revision is now accepted and ready to land.Thu, Jul 10, 8:01 PM
rpokala added a subscriber: rpokala.Thu, Jul 10, 8:59 PM
rpokala added inline comments.
share/man/man4/ufshci.4
117

Configured by who/what? Assuming the (R) means that this read-only, then either hardware or hard-coding is setting this value, so it is not really "configured".

Oh, but looking at the code, I see that it is flagged CTLFLAG_RW! So this should be marked (RW) here. Also, as above, this should have (in seconds).

j_yoon.choi_samsung.com updated this revision to Diff 158292.Thu, Jul 10, 11:56 PM
j_yoon.choi_samsung.com marked an inline comment as done.

Apply review comment

This revision now requires review to proceed.Thu, Jul 10, 11:56 PM
Harbormaster completed remote builds in B65328: Diff 158292.Thu, Jul 10, 11:56 PM
j_yoon.choi_samsung.com marked an inline comment as done.Thu, Jul 10, 11:57 PM
j_yoon.choi_samsung.com added inline comments.
share/man/man4/ufshci.4
117

My mistake, thanks for letting me know!

j_yoon.choi_samsung.com added a reviewer: rpokala.Thu, Jul 10, 11:58 PM
rpokala accepted this revision.Thu, Jul 10, 11:58 PM

Thanks!

This revision is now accepted and ready to land.Thu, Jul 10, 11:58 PM
j_yoon.choi_samsung.com marked an inline comment as done.Wed, Jul 16, 11:10 PM

Could you please commit this patch?

Closed by commit rG93f7ed6ca9cc: ufshci: add man page (authored by j_yoon.choi_samsung.com, committed by imp). · Explain WhyWed, Jul 16, 11:21 PM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG93f7ed6ca9cc: ufshci: add man page.
imp added a comment.Wed, Jul 16, 11:22 PM

Committed...

j_yoon.choi_samsung.com added a comment.Wed, Jul 16, 11:23 PM
In D51029#1172968, @imp wrote:

Committed...

Thank you! :)

Revision Contents
Changeset List

PathSize
share/
man/
man4/
5 lines
181 lines

Diff 158644

View Options

share/man/man4/Makefile

Loading...
View Options

share/man/man4/ufshci.4

Loading...