Page MenuHomeFreeBSD

ufshci: add man page
ClosedPublic

Authored by j_yoon.choi_samsung.com on Jun 25 2025, 1:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 2, 6:57 AM
Unknown Object (File)
Sun, Aug 31, 3:03 AM
Unknown Object (File)
Sat, Aug 30, 7:34 AM
Unknown Object (File)
Fri, Aug 29, 2:24 PM
Unknown Object (File)
Sat, Aug 23, 7:09 PM
Unknown Object (File)
Thu, Aug 21, 8:56 AM
Unknown Object (File)
Wed, Aug 20, 4:16 PM
Unknown Object (File)
Wed, Aug 20, 12:23 AM

Details

Summary

Sponsored by: Samsung Electronics

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This looks good as is.

This revision is now accepted and ready to land.Jul 9 2025, 3:08 AM

Other than that precision, nothing jumps out to me.

share/man/man4/ufshci.4
86

Worth stating the unit (seconds, milliseconds, or whichever)?

This revision now requires review to proceed.Jul 10 2025, 4:24 AM
j_yoon.choi_samsung.com added inline comments.
share/man/man4/ufshci.4
86

I added "(in seconds)". Thanks :)

This revision is now accepted and ready to land.Jul 10 2025, 8:01 PM
rpokala added inline comments.
share/man/man4/ufshci.4
117

Configured by who/what? Assuming the (R) means that this read-only, then either hardware or hard-coding is setting this value, so it is not really "configured".

Oh, but looking at the code, I see that it is flagged CTLFLAG_RW! So this should be marked (RW) here. Also, as above, this should have (in seconds).

j_yoon.choi_samsung.com marked an inline comment as done.

Apply review comment

This revision now requires review to proceed.Jul 10 2025, 11:56 PM
j_yoon.choi_samsung.com added inline comments.
share/man/man4/ufshci.4
117

My mistake, thanks for letting me know!

This revision is now accepted and ready to land.Jul 10 2025, 11:58 PM

Could you please commit this patch?

This revision was automatically updated to reflect the committed changes.