Sponsored by: Samsung Electronics
Details
Details
- Reviewers
imp julian pauamma_gundo.com rpokala - Group Reviewers
manpages - Commits
- rG93f7ed6ca9cc: ufshci: add man page
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 65075 Build 61958: arc lint + arc unit
Event Timeline
Comment Actions
Other than that precision, nothing jumps out to me.
| share/man/man4/ufshci.4 | ||
|---|---|---|
| 85 | Worth stating the unit (seconds, milliseconds, or whichever)? | |
| share/man/man4/ufshci.4 | ||
|---|---|---|
| 85 | I added "(in seconds)". Thanks :) | |
| share/man/man4/ufshci.4 | ||
|---|---|---|
| 117 | Configured by who/what? Assuming the (R) means that this read-only, then either hardware or hard-coding is setting this value, so it is not really "configured". Oh, but looking at the code, I see that it is flagged CTLFLAG_RW! So this should be marked (RW) here. Also, as above, this should have (in seconds). | |
| share/man/man4/ufshci.4 | ||
|---|---|---|
| 117 | My mistake, thanks for letting me know! | |