Page MenuHomeFreeBSD
Differential D50406

net80211: refactor out ifp->if_broadcastaddr into ieee80211_freebsd.c
ClosedPublic
Actions

Authored by adrian on Sun, May 18, 4:45 AM.
Tags
Referenced Files
F118084967: D50406.diff
Sun, May 25, 6:35 PM
Unknown Object (File)
Fri, May 23, 12:58 PM
Unknown Object (File)
Wed, May 21, 12:49 PM
Subscribers
bz
emaste
glebius
imp
melifaro

Details

Reviewers
bz
Group Reviewers
wireless
Commits
rGa278d11a60e0: net80211: refactor out ifp->if_broadcastaddr into ieee80211_freebsd.c
Summary
  • create ieee80211_vap_get_broadcast_address() to fetch the broadcast MAC address for the given VAP
  • refactor references to ifp->if_broadcastaddr -> ieee80211_vap_get_broadcast_address()

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 64414
Build 61298: arc lint + arc unit

Event Timeline

adrian created this revision.Sun, May 18, 4:45 AM
Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptSun, May 18, 4:45 AM
adrian requested review of this revision.Sun, May 18, 4:45 AM
Harbormaster completed remote builds in B64258: Diff 155640.Sun, May 18, 4:45 AM
adrian added a parent revision: D50405: net80211: migrate if_flags, if_drvflags out of most source files.Sun, May 18, 4:46 AM
adrian added a reviewer: wireless.
adrian added a project: wireless.
adrian added a child revision: D50407: net80211: remove direct references to ifp->if_xname.Sun, May 18, 5:00 AM
adrian updated this revision to Diff 155643.Sun, May 18, 5:58 AM

rebase

Harbormaster completed remote builds in B64261: Diff 155643.Sun, May 18, 5:58 AM
adrian mentioned this in D50023: net80211: move references to IF_LLADDR() into ieee80211_freebsd.c.Sun, May 18, 2:58 PM
bz accepted this revision.Sun, May 18, 8:16 PM
bz added a subscriber: bz.

Scrolling through apart from the local variable this looks good.

sys/net80211/ieee80211_freebsd.c
1328

Could pass vap->if_ifp here and save the local variable.

This revision is now accepted and ready to land.Sun, May 18, 8:16 PM
adrian updated this revision to Diff 155675.Mon, May 19, 4:11 AM

update from bz

This revision now requires review to proceed.Mon, May 19, 4:11 AM
Harbormaster completed remote builds in B64281: Diff 155675.Mon, May 19, 4:11 AM
adrian updated this revision to Diff 155724.Tue, May 20, 4:44 AM

comment from bz

Harbormaster completed remote builds in B64305: Diff 155724.Tue, May 20, 4:44 AM
adrian marked an inline comment as done.Tue, May 20, 4:45 AM
emaste added a subscriber: emaste.Thu, May 22, 4:43 PM
bz requested changes to this revision.Sat, May 24, 11:27 PM

Just style.

sys/net80211/ieee80211_freebsd.c
1326

return (...)

sys/net80211/ieee80211_hostap.c
563

Can't say in Phabricator if indentation is right..

sys/net80211/ieee80211_wds.c
491

again indent unclear in Phabricator

This revision now requires changes to proceed.Sat, May 24, 11:27 PM
adrian updated this revision to Diff 155995.Sun, May 25, 1:58 AM

comments from bz

Harbormaster completed remote builds in B64414: Diff 155995.Sun, May 25, 1:58 AM
bz accepted this revision.Sun, May 25, 1:38 PM
This revision is now accepted and ready to land.Sun, May 25, 1:38 PM
Closed by commit rGa278d11a60e0: net80211: refactor out ifp->if_broadcastaddr into ieee80211_freebsd.c (authored by adrian). · Explain WhySun, May 25, 3:25 PM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rGa278d11a60e0: net80211: refactor out ifp->if_broadcastaddr into ieee80211_freebsd.c.

Revision Contents
Changeset List

Diff 155995

View Options

sys/net80211/ieee80211_adhoc.c

Loading...
View Options

sys/net80211/ieee80211_freebsd.h

Loading...
View Options

sys/net80211/ieee80211_freebsd.c

Loading...
View Options

sys/net80211/ieee80211_hostap.c

Loading...
View Options

sys/net80211/ieee80211_ioctl.c

Loading...
View Options

sys/net80211/ieee80211_output.c

Loading...
View Options

sys/net80211/ieee80211_scan_sw.c

Loading...
View Options

sys/net80211/ieee80211_wds.c

Loading...