Page MenuHomeFreeBSD
Differential D50404

net80211: refactor the if_input call into ieee80211_vap_deliver_data()
ClosedPublic
Actions

Authored by adrian on May 18 2025, 4:19 AM.
Tags
Referenced Files
Unknown Object (File)
Tue, Sep 15, 12:14 PM
Unknown Object (File)
Tue, Sep 15, 11:11 AM
Unknown Object (File)
Tue, Sep 15, 6:16 AM
Unknown Object (File)
Mon, Sep 14, 11:47 PM
Unknown Object (File)
Sun, Sep 13, 2:26 AM
Unknown Object (File)
Sat, Sep 12, 1:37 PM
Unknown Object (File)
Thu, Sep 10, 6:12 PM
Unknown Object (File)
Thu, Sep 10, 10:00 AM
View All Files
Subscribers
bz
emaste
glebius
imp
melifaro

Details

Reviewers
bz
Group Reviewers
wireless
Commits
rG3f6a84ffbf39: net80211: refactor the if_input call into ieee80211_vap_deliver_data()
Summary

Refactor the two places where NET_EPOCH_ENTER; if_input; NET_EPOCH_EXIT
are called into a single spot in ieee80211_freebsd.c.

This removes both if_input references and puts all the NET_EPOCH stuff
into ieee80211_freebsd.c.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 64279
Build 61163: arc lint + arc unit

Event Timeline

adrian created this revision.May 18 2025, 4:19 AM
Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptMay 18 2025, 4:19 AM
adrian requested review of this revision.May 18 2025, 4:19 AM
Harbormaster completed remote builds in B64256: Diff 155638.May 18 2025, 4:19 AM
adrian added a parent revision: D50295: ixgbe: improve MDIO performance by reducing semaphore/IPC delays.May 18 2025, 4:20 AM
adrian added a reviewer: wireless.
adrian added a project: wireless.
adrian added a child revision: D50405: net80211: migrate if_flags, if_drvflags out of most source files.May 18 2025, 4:35 AM
adrian mentioned this in D50023: net80211: move references to IF_LLADDR() into ieee80211_freebsd.c.May 18 2025, 2:58 PM
bz accepted this revision.May 18 2025, 7:55 PM
bz added a subscriber: bz.

If you remove the local variable then this is fine (it's also fine this way). I may not see this again before Thu so please go ahead.

sys/net80211/ieee80211_freebsd.c
1238

Don't need that if you pass vap->iv_ifp to if_input

This revision is now accepted and ready to land.May 18 2025, 7:55 PM
adrian updated this revision to Diff 155673.May 19 2025, 4:00 AM

update from bz

This revision now requires review to proceed.May 19 2025, 4:00 AM
Harbormaster completed remote builds in B64279: Diff 155673.May 19 2025, 4:00 AM
adrian marked an inline comment as done.May 19 2025, 4:00 AM
emaste added a subscriber: emaste.May 22 2025, 4:43 PM
bz accepted this revision.May 24 2025, 11:20 PM
This revision is now accepted and ready to land.May 24 2025, 11:20 PM
Closed by commit rG3f6a84ffbf39: net80211: refactor the if_input call into ieee80211_vap_deliver_data() (authored by adrian). · Explain WhyMay 25 2025, 3:24 PM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rG3f6a84ffbf39: net80211: refactor the if_input call into ieee80211_vap_deliver_data().
adrian edited parent revisions, added: D50023: net80211: move references to IF_LLADDR() into ieee80211_freebsd.c; removed: D50295: ixgbe: improve MDIO performance by reducing semaphore/IPC delays.Oct 22 2025, 7:37 PM

Revision Contents
Changeset List

PathSize
sys/
net80211/
1 line
21 lines
7 lines
6 lines

Diff 155673

View Options

sys/net80211/ieee80211_freebsd.h

Loading...
View Options

sys/net80211/ieee80211_freebsd.c

Loading...
View Options

sys/net80211/ieee80211_hostap.c

Loading...
View Options

sys/net80211/ieee80211_input.c

Loading...