Page MenuHomeFreeBSD

rtwn: remove SEQ_SEL, replace with a QOS bit
ClosedPublic

Authored by adrian on Dec 15 2024, 6:20 PM.
Referenced Files
Unknown Object (File)
Mon, Sep 28, 5:53 PM
Unknown Object (File)
Mon, Sep 28, 5:36 PM
Unknown Object (File)
Fri, Sep 25, 11:52 PM
Unknown Object (File)
Fri, Sep 25, 6:14 PM
Unknown Object (File)
Fri, Sep 25, 1:04 AM
Unknown Object (File)
Wed, Sep 23, 4:12 PM
Unknown Object (File)
Mon, Sep 21, 4:20 PM
Unknown Object (File)
Mon, Sep 21, 9:03 AM
Subscribers

Details

Summary

I've reviewed all of the linux vendor and upstream drivers.
This SEQ_SEL field isn't a mask and doesn't ever look like it
it was; instead this bit is set to tag QoS data frames.

In fact, it effectively was set to 0 for STA frames and potentially 1
for broadcast/multicast frames as the STA macid of 0 and broadcast/
multicast macid of 1 maps to that. In AP modes it would be tagged
based on bit 0.

So, bring it in line with the vendor and linux drivers.

Locally tested:

  • RTL8192CU, STA, hostap
  • RTL8188EU, STA
  • RTL8192EU, STA

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 61176
Build 58060: arc lint + arc unit