Page MenuHomeFreeBSD

cleanup: remove support for EOL FreeBSD 13.2
ClosedPublic

Authored by rene on May 9 2024, 5:16 PM.
Tags
None
Referenced Files
F87693349: D45141.id139734.diff
Sat, Jul 6, 8:36 PM
F87693343: D45141.id139733.diff
Sat, Jul 6, 8:36 PM
F87693335: D45141.id139193.diff
Sat, Jul 6, 8:36 PM
Unknown Object (File)
Sat, Jul 6, 6:59 AM
Unknown Object (File)
Thu, Jul 4, 9:24 AM
Unknown Object (File)
Mon, Jul 1, 8:33 PM
Unknown Object (File)
Sat, Jun 29, 7:39 PM
Unknown Object (File)
Sat, Jun 29, 12:23 AM
Subscribers

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 57883
Build 54771: arc lint + arc unit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Skimmed through all changes, but didn't run-test.

This revision is now accepted and ready to land.May 9 2024, 5:38 PM

Can you also drop annotated cruft?

$ git grep -lF 'FreeBSD 13.2 EOL'
devel/hyprlang/Makefile
emulators/rpcs3/Makefile
emulators/yuzu/Makefile
x11/hyprcursor/Makefile
x11/hyprlock/Makefile
x11/xdg-desktop-portal-hyprland/Makefile
x11-toolkits/como/Makefile
x11-wm/gamescope/Makefile
x11-wm/hyprland/Makefile
x11-wm/theseus-ship/Makefile
graphics/nvidia-drm-510-kmod/Makefile
15

Do you plan to remove the actual file as well?

  • cleanup: remove more EOL FreeBSD 13.2 code
This revision now requires review to proceed.May 9 2024, 7:51 PM
rene marked an inline comment as done.May 9 2024, 7:54 PM

Incorporated suggestions from @jbeich , updated TIMESTAMPs of affected distinfo files.

This revision is now accepted and ready to land.May 10 2024, 9:03 AM
ashish requested changes to this revision.May 10 2024, 8:48 PM

editors/kakoune need to be skipped, as I recently updated it, and removed those lines, and so the editors/kakoune/Makefile part of this patch isn't applicable anymore.

Thanks!

This revision now requires changes to proceed.May 10 2024, 8:48 PM

Rebase, drop obsoleted patch for editors/kakoune

This revision is now accepted and ready to land.May 11 2024, 2:26 PM

Changes to games/flightgear look good to me. Thanks!

The changes for devel/electron* look good. Thanks for taking care of those ports.

This revision now requires review to proceed.May 23 2024, 8:07 PM
vvd added inline comments.
emulators/virtualbox-ose-legacy/Makefile
199

I think we can remove this line too - it's old 14-CURRENT before create stable/14.

emulators/virtualbox-ose-legacy/Makefile
200

We must remove this too.
13.3 is affected too and require LLVM 15 for build this version of the VirtualBox.

emulators/virtualbox-ose-legacy/Makefile
199

Probably cleaner to remove it with 14.0-EOL ?

200

From the comment in the Makefile it looks like a ${OSVERSION} > 1303000 must be added instead?

emulators/virtualbox-ose-legacy/Makefile
199

It isn't 14.0 - it's 14-CURRENT.
14-CURRENT is EOL since 14.0 released, isn't it?

200

There is work for build it with LLVM from base: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279257

emulators/virtualbox-ose-legacy/Makefile
200

It looks like a separate issue from dropping 13.2

No objections for ports I maintain.

This revision is now accepted and ready to land.May 29 2024, 7:43 PM
This revision now requires review to proceed.Tue, Jun 11, 7:30 PM

devel/electron30: cleanup post 13.2

sunpoet requested changes to this revision.EditedTue, Jun 18, 9:46 AM

Please add www/nghttp2. Thanks.

diff --git a/www/nghttp2/Makefile b/www/nghttp2/Makefile
index 440601480831..daec34b12a14 100644
--- a/www/nghttp2/Makefile
+++ b/www/nghttp2/Makefile
@@ -45,11 +45,6 @@ HPACK_LIB_DEPENDS=   libjansson.so:devel/jansson

 .include <bsd.port.options.mk>

-.if ${OSREL} == 13.2
-USES+=             llvm
-EXTRA_PATCHES=     ${PATCHDIR}/extra-patch-compatibility-fix
-.endif
-
 .if ${OSREL} == 14.0
 EXTRA_PATCHES= ${PATCHDIR}/extra-patch-compatibility-fix
 .endif
This revision now requires changes to proceed.Tue, Jun 18, 9:46 AM
  • all: remove support for expired FreeBSD 13.2
  • www/nghttp2: remove 13.2 compat
This revision is now accepted and ready to land.Tue, Jun 18, 7:42 PM
This revision now requires review to proceed.Sat, Jun 22, 12:08 PM

More libc++ < 16 workarounds to remove:

$ rg -lF FreeBSD\ 13.2
deskutils/plasma6-xdg-desktop-portal-kde/files/patch-src_session.h
devel/hyprutils/Makefile
graphics/wrapland/Makefile
databases/arrow/Makefile
184

Better completely revert bd78a1b4103a.

emulators/rpcs3/Makefile
97–98

Clean up distinfo after 8b3b56eaa45b rebase.

  • rebase
  • clean up some more ports, info from jbeich@
  • databases/arrow: cleanup, from jbeich@
This revision was not accepted when it landed; it landed in state Needs Review.Mon, Jul 1, 8:32 PM
This revision was automatically updated to reflect the committed changes.